Skip to content

Commit c2a7881

Browse files
jhovoldgregkh
authored andcommitted
pinctrl: qcom: spmi-gpio: drop broken pm8008 support
commit 8da8649 upstream. The SPMI GPIO driver assumes that the parent device is an SPMI device and accesses random data when backcasting the parent struct device pointer for non-SPMI devices. Fortunately this does not seem to cause any issues currently when the parent device is an I2C client like the PM8008, but this could change if the structures are reorganised (e.g. using structure randomisation). Notably the interrupt implementation is also broken for non-SPMI devices. Also note that the two GPIO pins on PM8008 are used for interrupts and reset so their practical use should be limited. Drop the broken GPIO support for PM8008 for now. Fixes: ea119e5 ("pinctrl: qcom-pmic-gpio: Add support for pm8008") Cc: [email protected] # 5.13 Reviewed-by: Bryan O'Donoghue <[email protected]> Reviewed-by: Stephen Boyd <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 9b95f63 commit c2a7881

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

-1
Original file line numberDiff line numberDiff line change
@@ -1207,7 +1207,6 @@ static const struct of_device_id pmic_gpio_of_match[] = {
12071207
{ .compatible = "qcom,pm7325-gpio", .data = (void *) 10 },
12081208
{ .compatible = "qcom,pm7550ba-gpio", .data = (void *) 8},
12091209
{ .compatible = "qcom,pm8005-gpio", .data = (void *) 4 },
1210-
{ .compatible = "qcom,pm8008-gpio", .data = (void *) 2 },
12111210
{ .compatible = "qcom,pm8019-gpio", .data = (void *) 6 },
12121211
/* pm8150 has 10 GPIOs with holes on 2, 5, 7 and 8 */
12131212
{ .compatible = "qcom,pm8150-gpio", .data = (void *) 10 },

0 commit comments

Comments
 (0)