Skip to content

Commit aee4059

Browse files
committed
[benchmarks] Minor repairs.
1 parent 35ad9b0 commit aee4059

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/actions/run-benchmarks/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ runs:
6666
cd ..
6767
if [[ -z $EXISTING_FILE ]]; then
6868
mkdir -p ${{ inputs.repo-for-saving-data }}/$OUTPUT_DIR
69-
echo "The collected benchmark results will be saved to $OUTPUT_FILE."
69+
echo "The collected benchmark results will be saved to $OUTPUT_DIR/$OUTPUT_FILENAME."
7070
echo "::set-output name=output-file::$OUTPUT_DIR/$OUTPUT_FILENAME"
7171
else
7272
echo "The benchmark will not be run because results for that commit are already saved at $EXISTING_FILE."

.github/actions/visualize-save-upload/action.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,11 @@ runs:
5959
run: |
6060
echo $(ls)
6161
if [ -f errors.txt ]; then
62-
ERROR_MESSAGES=$(cat errors.txt)
63-
echo "The benchmark runner reported the following errors:\n$ERROR_MESSAGES"
64-
echo "::set-output name=error-messages::Error messages: $ERROR_MESSAGES"
62+
ERROR_MESSAGES="The benchmark runner reported the following errors:"$'\n'"$(cat errors.txt)"
63+
echo "$ERROR_MESSAGES"
64+
echo 'ERROR_MESSAGES<<EOF' >> $GITHUB_ENV
65+
echo "$ERROR_MESSAGES" >> $GITHUB_ENV
66+
echo 'EOF' >> $GITHUB_ENV
6567
fi
6668
shell: bash
6769

@@ -70,7 +72,7 @@ runs:
7072
with:
7173
message: |
7274
Running benchmarks from commit ${{ github.sha }}...
73-
${{ steps.compute-error-messages.outputs.error-messages }}
75+
${{ env.ERROR_MESSAGES }}
7476
7577
Results so far:
7678
@@ -85,7 +87,7 @@ runs:
8587
with:
8688
message: |
8789
:heavy_check_mark: Finished running benchmarks from ${{ github.sha }}.
88-
${{ steps.compute-error-messages.outputs.error-messages }}
90+
${{ env.ERROR_MESSAGES }}
8991
9092
![Visualization of the benchmark results.](https://raw.githubusercontent.com/lf-lang/${{ inputs.repo-for-saving-data }}/saved-benchmark-results/${{ steps.figure.outputs.output-file }})
9193
comment_includes: ${{ github.sha }}

0 commit comments

Comments
 (0)