-
Notifications
You must be signed in to change notification settings - Fork 897
libgit2 StdCall (/Gz) calling convention #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We need to build with |
In order to discuss this further, below some related references on those topics stdcall/cdecl:
ssh:
#205 was a proposal showing how to implement cdecl calling convention with working callbacks. I'm fully ok to re-open the calling convention subject provided we all reach an agreement 😉. |
/cc @igor-gorbunov |
Thanks for the references. I've posted some thoughts on how I think this could be solved to #888. That way we would not need any changes to LibGit2Sharp. But regarding [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
delegate ... |
We're keeping stdcall. There is no need for OpenSSL for libssh2 to work, so they no longer set the calling convention. If libssh2 does not support stdcall when using Windows crypto that's a bug to be filed with them. |
I've been trying to get an SSL/SSH2 enabled build of libgit2 going on, but unfortunately OpenSSL is pretty hard to compile with
/Gz
. It'd be best if LibGit2Sharp could consume a usual (cdecl
) build of libgit2.Is there some specific reason that LibGit2Sharp needs libgit2 to be compiled as
stdcall
?The text was updated successfully, but these errors were encountered: