chore: move xml-edit to a script

Author: jooola

Dockerfile

@@ -54,12 +54,15 @@ ENV USER=icecast
 
 RUN adduser --disabled-password --gecos '' --no-create-home $USER
 
+COPY docker-entrypoint.sh /usr/local/bin/docker-entrypoint
+COPY xml-edit.sh /usr/local/bin/xml-edit
+RUN chmod +x \
+    /usr/local/bin/docker-entrypoint \
+    /usr/local/bin/xml-edit
+
 COPY --from=builder /build/output /
 RUN chown $USER:$USER /etc/icecast.xml
 
-COPY docker-entrypoint.sh /usr/local/bin/docker-entrypoint
-RUN chmod +x /usr/local/bin/docker-entrypoint
-
 RUN install --directory --owner=$USER \
     /var/log/icecast
 

docker-entrypoint.sh

@@ -1,38 +1,35 @@
 #!/bin/sh
 
-xml_edit() {
-  tag="$1"
-  value="$2"
-  RESULT=$(sed -e "s|<${tag}>[^<]*</${tag}>|<${tag}>${value}</${tag}>|g" /etc/icecast.xml) &&
-    echo "$RESULT" > /etc/icecast.xml
+edit_icecast_config() {
+  xml-edit "$@" /etc/icecast.xml
 }
 
 if [ -n "$ICECAST_SOURCE_PASSWORD" ]; then
-  xml_edit source-password "$ICECAST_SOURCE_PASSWORD"
+  edit_icecast_config source-password "$ICECAST_SOURCE_PASSWORD"
 fi
 if [ -n "$ICECAST_RELAY_PASSWORD" ]; then
-  xml_edit relay-password "$ICECAST_RELAY_PASSWORD"
+  edit_icecast_config relay-password "$ICECAST_RELAY_PASSWORD"
 fi
 if [ -n "$ICECAST_ADMIN_PASSWORD" ]; then
-  xml_edit admin-password "$ICECAST_ADMIN_PASSWORD"
+  edit_icecast_config admin-password "$ICECAST_ADMIN_PASSWORD"
 fi
 if [ -n "$ICECAST_ADMIN_USERNAME" ]; then
-  xml_edit admin-user "$ICECAST_ADMIN_USERNAME"
+  edit_icecast_config admin-user "$ICECAST_ADMIN_USERNAME"
 fi
 if [ -n "$ICECAST_ADMIN_EMAIL" ]; then
-  xml_edit admin "$ICECAST_ADMIN_EMAIL"
+  edit_icecast_config admin "$ICECAST_ADMIN_EMAIL"
 fi
 if [ -n "$ICECAST_LOCATION" ]; then
-  xml_edit location "$ICECAST_LOCATION"
+  edit_icecast_config location "$ICECAST_LOCATION"
 fi
 if [ -n "$ICECAST_HOSTNAME" ]; then
-  xml_edit hostname "$ICECAST_HOSTNAME"
+  edit_icecast_config hostname "$ICECAST_HOSTNAME"
 fi
 if [ -n "$ICECAST_MAX_CLIENTS" ]; then
-  xml_edit clients "$ICECAST_MAX_CLIENTS"
+  edit_icecast_config clients "$ICECAST_MAX_CLIENTS"
 fi
 if [ -n "$ICECAST_MAX_SOURCES" ]; then
-  xml_edit sources "$ICECAST_MAX_SOURCES"
+  edit_icecast_config sources "$ICECAST_MAX_SOURCES"
 fi
 
 exec "$@"

xml-edit.sh

@@ -0,0 +1,20 @@
+#!/bin/sh -eu
+
+usage() {
+  cat >&2 <<- EOF
+Usage : $0 <tag> <value> <file>
+
+EOF
+}
+
+if test $# -lt 3; then
+  usage
+  exit 1
+fi
+
+tag="$1"
+value="$2"
+file="$3"
+
+result=$(sed -e "s|<${tag}>[^<]*</${tag}>|<${tag}>${value}</${tag}>|g" "$file") || exit 1
+echo "$result" > "$file"