quakespasm (sdl2 version) broken

[sezero]

See screen shot below: The in-game screenshot facility (glReadPixels) works, so, SwapBuffers isn't working??

This is on i686-linux, gnome2, pure x11, with 2.32.56 release + SDL3 from current git HEAD.

Can anyone reproduce?

[andreymal]

In my case, downgrading sdl2-compat to 2.32.54 does not fix quakespasm, but downgrading sdl3 to 3.2.10 fixes it

[sezero]

You seem correct: I locally reverted ae77bfa so that it accepts 3.2.10, running against 3.2.10 is good, 3.2.12 as well as git main are bad.

[Kontrabant]

The only thing I can think of is line 539 in src/video/x11/SDL_x11window.c

const bool use_resize_sync = !!(window->flags & SDL_WINDOW_OPENGL); // Doesn't work well with Vulkan

Try commenting out the flag test and force it to false. This is the only vaguely x11 related GL change I can think of in recent memory.

Possibly related to #482 as well?

[sezero]

The only thing I can think of is line 539 in src/video/x11/SDL_x11window.c

const bool use_resize_sync = !!(window->flags & SDL_WINDOW_OPENGL); // Doesn't work well with Vulkan

Try commenting out the flag test and force it to false. This is the only vaguely x11 related GL change I can think of in recent memory.

Changing that line to const bool use_resize_sync = false; did not help. (main branch)

[andreymal]

Bisected to libsdl-org/SDL@3b91017 — this commit is broken, its parent is working

(I have no idea how can this be related to PulseAudio 🤯)

But yes, commenting out the SDL_CleanupTLS(); line in src/audio/pulseaudio/SDL_pulseaudio.c does fix quakespasm (main branch)

[andreymal]

By the way, this also fixes Xonotic's black screen

[sezero]

Bisected to libsdl-org/SDL@3b91017 — this commit is broken, its parent is working

But yes, commenting out the SDL_CleanupTLS(); line in src/audio/pulseaudio/SDL_pulseaudio.c does fix quakespasm (main branch)

By the way, this also fixes Xonotic's black screen

CC @icculus

[sezero]

Running with SDL_AUDIODRIVER=alsa set does make it display the game properly.

But, I see a lot of the following on my terminal. (This is with alsa-lib-1.1.0,
btw...)

ALSA lib conf.c:4738:(snd_config_expand) Unknown parameters 0
ALSA lib control.c:954:(snd_ctl_open_noupdate) Invalid CTL sysdefault:0
ALSA lib conf.c:4738:(snd_config_expand) Unknown parameters 1
ALSA lib control.c:954:(snd_ctl_open_noupdate) Invalid CTL sysdefault:1
ALSA lib conf.c:4738:(snd_config_expand) Unknown parameters 0
ALSA lib control.c:954:(snd_ctl_open_noupdate) Invalid CTL sysdefault:0
ALSA lib conf.c:4738:(snd_config_expand) Unknown parameters 1
ALSA lib control.c:954:(snd_ctl_open_noupdate) Invalid CTL sysdefault:1

[icculus]

Yeah, we're just going to revert that commit. A more-careful version that doesn't fire on a real thread would be better, but the leak wasn't serious enough for the chaos it causes.

[slouken]

SDL 3.2.14 with the fix for the bug is now available!