You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove some useless tests in functional_tests and reject huge chans
In general we shouldn't have tests lying around that are useless as
its not genuinely testing anything and may break due to harmless
protocol changes. Here, we drop a few useless tests.
Specifically,
* We drop a test that the channel_reserve is greater than the
dust_limit on a random specific channel value - of *course* the
channel reserve (1% of the channel - 1000 sats) happens to be
greater than the dust limit (~300 sats).
* We drop a test that we don't set any bits in `channel_flags`
aside from 1 which is fairly useless, but more importantly its
actually just testing that we don't change code, not that we are
doing some specific behavior correctly.
* We also drop a test that public keys are valid - `PublicKey`s
are always valid per the `secp256k1` API, so should be tested by
`secp256k1`, not us.
Further, we remove a test that channels of 2^24 (ie 26) sats fail
to open, which was intended to test pre-WUMBO channel rejection,
but actually tested too-small channels (and we have other tests for
WUMBO channels).
let node0_to_1_send_open_channel = get_event_msg!(nodes[0],MessageSendEvent::SendOpenChannel, node_b_id);
4691
4679
4692
4680
// BOLT #2 spec: Sending node should set to_self_delay sufficient to ensure the sender can irreversibly spend a commitment transaction output, in case of misbehaviour by the receiver.
// BOLT #2 spec: Sending node must set funding_pubkey, revocation_basepoint, htlc_basepoint, payment_basepoint, and delayed_payment_basepoint to valid DER-encoded, compressed, secp256k1 pubkeys.
0 commit comments