Fix string_length function so that it always returns. (#144148)

amykhuang · web-flow · commit c42912b8c96f · 2025-06-13T13:07:39.000-07:00
Previously setting LIBC_COPT_STRING_UNSAFE_WIDE_READ would cause a build
error because there is a path in the ifdef that doesn't return anything.
diff --git a/libc/src/string/string_utils.h b/libc/src/string/string_utils.h
@@ -90,12 +90,11 @@ template <typename T> LIBC_INLINE size_t string_length(const T *src) {
   // string a block at a time.
   if constexpr (cpp::is_same_v<T, char>)
     return string_length_wide_read<unsigned int>(src);
-#else
+#endif
   size_t length;
   for (length = 0; *src; ++src, ++length)
     ;
   return length;
-#endif
 }
 
 template <typename Word>

Original file line number	Diff line number	Diff line change
`@@ -90,12 +90,11 @@ template <typename T> LIBC_INLINE size_t string_length(const T *src) {`
`90`	`90`	`// string a block at a time.`
`91`	`91`	`if constexpr (cpp::is_same_v<T, char>)`
`92`	`92`	`return string_length_wide_read<unsigned int>(src);`
`93`		`-#else`
	`93`	`+#endif`
`94`	`94`	`size_t length;`
`95`	`95`	`for (length = 0; *src; ++src, ++length)`
`96`	`96`	`;`
`97`	`97`	`return length;`
`98`		`-#endif`
`99`	`98`	`}`
`100`	`99`
`101`	`100`	`template <typename Word>`