ci fixes

Author: jflearn

.github/workflows/ci.yml

@@ -34,14 +34,14 @@ jobs:
           --coverage-clover ./coverage.xml
       - name: Annotate with Metrics
         run: |
-          find src -name "*.php" | xargs ./vendor/bin/metrics annotate ./coverage.xml
+          find src -name "*.php" | xargs -n 1 ./vendor/bin/metrics annotate ./coverage.xml
       - name: Refactor with Rector
         run: |
           ./vendor/bin/rector process src
       - name: Tidy Source Code
         run: |
-          find tests -name "*.php" | xargs ./vendor/bin/phptidy.php replace
-          find src -name "*.php" | xargs ./vendor/bin/phptidy.php replace
+          find tests -name "*.php" | xargs -n 1 ./vendor/bin/phptidy.php replace
+          find src -name "*.php" | xargs -n 1 ./vendor/bin/phptidy.php replace
       - name: Push Back Changes
         run: |
           git diff --exit-code src || ( \

phpunit.xml.dist

@@ -1,20 +1,29 @@
-<?xml version="1.0"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/silverstripe/cms/tests/bootstrap.php" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
-  <coverage includeUncoveredFiles="true">
-    <include>
-      <directory suffix=".php">src/</directory>
-    </include>
-    <exclude>
-      <directory suffix=".php">tests/</directory>
-    </exclude>
-    <report>
-      <clover outputFile="clover.xml"/>
-    </report>
-  </coverage>
-  <testsuite name="Default">
-    <directory>tests/</directory>
-  </testsuite>
-  <logging/>
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         executionOrder="depends,defects"
+         forceCoversAnnotation="false"
+         beStrictAboutCoversAnnotation="true"
+         beStrictAboutOutputDuringTests="true"
+         beStrictAboutTodoAnnotatedTests="true"
+         failOnRisky="true"
+         failOnWarning="true"
+         verbose="true">
+    <testsuites>
+        <testsuite name="default">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+
+    <coverage processUncoveredFiles="true">
+        <include>
+            <directory suffix=".php">src</directory>
+        </include>
+        <exclude>
+            <file>src/bootstrap.php</file>
+        </exclude>
+    </coverage>
   <php>
     <includePath>app/code</includePath>
     <env name="SS_DATABASE_CLASS" value="SQLite3Database"/>

src/Widgets/UserFormWidget.php

@@ -34,7 +34,6 @@ class UserFormWidget extends Widget
 
 	/**
 	 *
-	 * @Metrics( crap = 1 )
 	 * @return unknown
 	 */