Skip to content

DateString not exposed as TypeScript type - prevents use in Loopback 4 #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamincburns opened this issue Dec 9, 2020 · 6 comments
Closed

Comments

@benjamincburns
Copy link

Steps to reproduce

  1. Try adding a property of type DateString to a TypeScript model in loopback 4.

Current Behavior

Can't import type DateString because it's implemented in pure JS and not exposed by any type declaration file.

Expected Behavior

I'd be able to do something like import { DateString } from "loopback-datasource-juggler" in TypeScript code.

It would appear that this is possible, as DateString is listed on the Loopback types page in the Loopback 4 docs.

Link to reproduction sandbox

There's nothing to sandbox because the code won't even compile.

@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2021
@benjamincburns
Copy link
Author

@achrinza similar to my comment on another issue - if you agree that this bug is valid, perhaps it should be ignored by stalebot.

@stale stale bot removed the stale label Jul 15, 2021
@achrinza
Copy link
Member

achrinza commented Sep 3, 2021

Apologies for missing the issue; This would be solved with the addition of type definitions to Juggler.

Currently we don't have the resources to implement the typedefs and tests right now but are open to community contributions.

As for stalebot, it acts as a gentle reminder that the issue is still open; So if the issue is still valid, we'll remove the stale tag :)

@achrinza
Copy link
Member

Currently being worked on by: #1902

@stale
Copy link

stale bot commented Nov 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 12, 2021
@benjamincburns
Copy link
Author

Closing, as #1902 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants