rspec

Author: lucadevitis-msm

lib/puppetfiles/bin/add_module.rb

@@ -0,0 +1,26 @@
+require 'puppetfiles'
+# @author Luca De Vitis <luca.devitis at moneysupermarket.com>
+module Puppetfiles
+  # This (MixIn) module contains the logic to be performed on loaded
+  # `Puppetfile`s. All methods work assuming there is a `config` method (an
+  # `attr_accessor`, for example) that can return a `Hash` of options `:name
+  # => value`.
+  module Bin
+    # Update 1 module details in all provided puppetfiles that contain it
+    module AddModule
+      # Run the module update
+      def run
+        mod = argv.first
+        files = argv.drop(1)
+        version = config[:version]
+        keys = [:git, :ref]
+        options = keys.map { |k| [k, config[k]] if config[k] }.compact.to_h
+        ::Puppetfiles.load files
+        ::Puppetfiles.add mod, version, options
+        loaded = ::Puppetfiles.loaded.count
+        ::Puppetfiles.save
+        ok "#{mod} has been added to #{loaded} Puppetfiles"
+      end
+    end
+  end
+end

lib/puppetfiles/bin/remove_module.rb

@@ -0,0 +1,24 @@
+require 'puppetfiles'
+# @author Luca De Vitis <luca.devitis at moneysupermarket.com>
+module Puppetfiles
+  # This (MixIn) module contains the logic to be performed on loaded
+  # `Puppetfile`s. All methods work assuming there is a `config` method (an
+  # `attr_accessor`, for example) that can return a `Hash` of options `:name
+  # => value`.
+  module Bin
+    # Remove 1 module details in all provided puppetfiles that contain it
+    module RemoveModule
+      # Run the module remove procedure
+      def run
+        mod = argv.first
+        files = argv.drop(1)
+        ::Puppetfiles.load files
+        ::Puppetfiles.remove mod
+        loaded = ::Puppetfiles.loaded.count
+        updated = ::Puppetfiles.loaded.count
+        ::Puppetfiles.save
+        ok "#{loaded} Puppetfiles, `#{mod}' removed from #{updated}"
+      end
+    end
+  end
+end

lib/puppetfiles/bin/update_module.rb

@@ -17,9 +17,10 @@ def run
         options = keys.map { |k| [k, config[k]] if config[k] }.compact.to_h
         ::Puppetfiles.load files
         ::Puppetfiles.update mod, version, options
+        loaded = ::Puppetfiles.loaded.count
+        updated = ::Puppetfiles.loaded.count
         ::Puppetfiles.save
-        ok "#{::Puppetfiles.loaded.count} Puppetfiles, " \
-           "#{::Puppetfiles.updated.count} updated"
+        ok "#{loaded} Puppetfiles, `#{mod}' updated on #{updated}"
       end
     end
   end

puppetfiles.gemspec

@@ -21,8 +21,8 @@ Gem::Specification.new do |spec|
 
   spec.files = `git ls-files -z`.split("\x0")
   spec.files.reject! { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir = 'exe'
-  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = 'bin'
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.11'

spec/bin/update_module_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+require 'puppetfiles/bin/update_module'
+
+class UpdateModule
+  include Puppetfiles::Bin::UpdateModule
+  attr_accessor :config, :argv, :status, :output
+  def initialize(argv, config)
+    @argv = argv
+    @config = config
+    @output = ''
+  end
+
+  def output(msg = nil)
+    return @output unless msg
+    @output << msg
+    nil
+  end
+
+  { ok: 0, warning: 1, critical: 2, unknown: 3 }.each do |name, code|
+    define_method(name) do |*args|
+      @status = code
+      output(*args)
+      exit(code)
+    end
+  end
+end
+
+describe Puppetfiles::Bin::UpdateModule do
+  let(:puppetfile) { Tempfile.new('Puppetfile.update') }
+  let(:mod1) { { name: 'mod1', version: '1.0.0', options: {} } }
+  let(:mod2) do
+    { name: 'mod2',
+      version: '',
+      options: { git: '[email protected]:user/repo.git', ref: '1.0.0' } }
+  end
+  let(:value) { 'whatever' }
+
+  before(:example) do
+    ::Puppetfiles.dump([{ path: puppetfile.path, modules: [mod1, mod2] }])
+  end
+  after(:example) { puppetfile.close! }
+
+  context 'with `:version` set' do
+    let(:script) do
+      UpdateModule.new([mod1[:name], puppetfile.path], version: value)
+    end
+    it 'should update module version' do
+      expect { script.run }.to raise_error(SystemExit)
+      expect(script.status).to eq(0)
+      loaded = ::Puppetfiles.load [puppetfile.path]
+      found = loaded.first[:modules].find { |m| m[:name] == mod1[:name] }
+      expect(found).to be_truthy
+      expect(found[:version]).to eq(value)
+    end
+  end
+  [:git, :ref].each do |name|
+    context "with option `:#{name}` set" do
+      let(:script) do
+        UpdateModule.new([mod2[:name], puppetfile.path], name => value)
+      end
+      it "should update module option `:#{name}`" do
+        expect { script.run }.to raise_error(SystemExit)
+        expect(script.status).to eq(0)
+        loaded = ::Puppetfiles.load [puppetfile.path]
+        found = loaded.first[:modules].find { |m| m[:name] == mod2[:name] }
+        expect(found).to be_truthy
+        expect(found[:options][name]).to eq(value)
+      end
+    end
+  end
+end