Fix dragging GUI tabs resulting in a crash

ychin · ychin · commit d8155a754639 · 2024-09-10T18:46:24.000-07:00
This was introduced by #1457 which was supposed to be a simple compiler warning cleanup but it introduced a signed integer bug. Fix that here. Fix #1473
diff --git a/src/MacVim/PSMTabBarControl/source/PSMTabDragAssistant.m b/src/MacVim/PSMTabBarControl/source/PSMTabDragAssistant.m
@@ -386,7 +386,7 @@ - (void)distributePlaceholdersInTabBar:(PSMTabBarControl *)control
 
 - (void)removeAllPlaceholdersFromTabBar:(PSMTabBarControl *)control
 {
-    NSUInteger i, cellCount = [[control cells] count];
+    int i, cellCount = (int)[[control cells] count];
     for(i = (cellCount - 1); i >= 0; i--){
         PSMTabBarCell *cell = [[control cells] objectAtIndex:i];
         if([cell isPlaceholder])

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,7 @@ - (void)distributePlaceholdersInTabBar:(PSMTabBarControl *)control`
`386`	`386`
`387`	`387`	`- (void)removeAllPlaceholdersFromTabBar:(PSMTabBarControl *)control`
`388`	`388`	`{`
`389`		`- NSUInteger i, cellCount = [[control cells] count];`
	`389`	`+ int i, cellCount = (int)[[control cells] count];`
`390`	`390`	`for(i = (cellCount - 1); i >= 0; i--){`
`391`	`391`	`PSMTabBarCell *cell = [[control cells] objectAtIndex:i];`
`392`	`392`	`if([cell isPlaceholder])`