Updates to get linting working

Author: bengriffin1

.eslintrc

@@ -14,7 +14,11 @@
     "no-cond-assign": 0,
     "class-methods-use-this": 0,
     "no-underscore-dangle": 0,
-    "no-useless-constructor": 0
+    "no-useless-constructor": 0,
+    // Note: you must disable the base rule as it can report incorrect errors
+    "no-shadow": 0,
+    "@typescript-eslint/no-shadow": "warn",
+    "no-empty-function": 0
   },
   "settings": {
     "import/resolver": {

src/core/sdk-exceptions.ts

@@ -5,7 +5,11 @@ import { ErrorCode } from '../types';
 export class MagicAdminSDKError extends Error {
   __proto__ = Error;
 
-  constructor(public code: ErrorCode, message: string, public data: any[] = []) {
+  constructor(
+    public code: ErrorCode,
+    message: string,
+    public data: any[] = [],
+  ) {
     super(`Magic Admin SDK Error: [${code}] ${message}`);
     Object.setPrototypeOf(this, MagicAdminSDKError.prototype);
   }

src/core/sdk.ts

@@ -1,9 +1,9 @@
+import { createApiKeyMissingError } from './sdk-exceptions';
 import { TokenModule } from '../modules/token';
 import { UsersModule } from '../modules/users';
 import { UtilsModule } from '../modules/utils';
 import { MagicAdminSDKAdditionalConfiguration } from '../types';
 import { get } from '../utils/rest';
-import { createApiKeyMissingError } from './sdk-exceptions';
 
 export class MagicAdminSDK {
   public readonly apiBaseUrl: string;
@@ -35,7 +35,10 @@ export class MagicAdminSDK {
    * @param secretApiKey
    * @param options
    */
-  constructor(public readonly secretApiKey?: string, options?: MagicAdminSDKAdditionalConfiguration) {
+  constructor(
+    public readonly secretApiKey?: string,
+    options?: MagicAdminSDKAdditionalConfiguration,
+  ) {
     const endpoint = options?.endpoint ?? 'https://api.magic.link';
     this.apiBaseUrl = endpoint.replace(/\/+$/, '');
     this.clientId = options?.clientId ?? null;

src/types/utils-types.ts

@@ -1,5 +1,5 @@
 export interface ValidateTokenOwnershipResponse {
-    valid: boolean;
-    error_code: string;
-    message: string;
+  valid: boolean;
+  error_code: string;
+  message: string;
 }

src/utils/parse-didt.ts

@@ -1,7 +1,7 @@
-import { Claim, ParsedDIDToken } from '../types';
+import { decodeValue } from './codec';
 import { isDIDTClaim } from './type-guards';
 import { createMalformedTokenError } from '../core/sdk-exceptions';
-import { decodeValue } from './codec';
+import { Claim, ParsedDIDToken } from '../types';
 
 interface ParseDIDTokenResult {
   raw: [string, string];

src/utils/rest.ts

@@ -1,8 +1,9 @@
 import { RequestInit } from 'node-fetch';
-import { createServiceError } from '../core/sdk-exceptions';
+
 import { fetch } from './fetch';
+import { createServiceError } from '../core/sdk-exceptions';
 
-interface MagicAPIResponse<TData = {}> {
+interface MagicAPIResponse<TData> {
   data?: TData;
   error_code?: string;
   message?: string;
@@ -12,10 +13,10 @@ interface MagicAPIResponse<TData = {}> {
 /**
  * Performs a `fetch` to the given URL with the configured `init` object.
  */
-async function emitRequest<TResponse extends any = {}>(url: string, init?: RequestInit): Promise<Partial<TResponse>> {
+async function emitRequest<TResponse>(url: string, init?: RequestInit): Promise<Partial<TResponse>> {
   const json: MagicAPIResponse<TResponse> = await fetch(url, init)
-    .then(res => res.json())
-    .catch(err => {
+    .then((res) => res.json())
+    .catch((err) => {
       throw createServiceError(err);
     });
 
@@ -29,7 +30,7 @@ async function emitRequest<TResponse extends any = {}>(url: string, init?: Reque
 /**
  * Generates an encoded URL with query string from a dictionary of values.
  */
-function generateQuery<T extends Record<string, string | number | boolean> = {}>(url: string, params?: T) {
+function generateQuery<T extends Record<string, string | number | boolean>>(url: string, params?: T) {
   let query = '?';
   if (params) {
     for (const [key, value] of Object.entries(params)) query += `${key}=${value}&`;
@@ -41,7 +42,7 @@ function generateQuery<T extends Record<string, string | number | boolean> = {}>
 /**
  * POSTs to Magic's API.
  */
-export function post<TBody extends Record<string, string | number | boolean> = {}, TResponse extends any = {}>(
+export function post<TBody extends Record<string, string | number | boolean>, TResponse>(
   url: string,
   secretApiKey: string,
   body: TBody,
@@ -56,7 +57,7 @@ export function post<TBody extends Record<string, string | number | boolean> = {
 /**
  * GETs from Magic's API.
  */
-export function get<TResponse extends any = {}>(url: string, secretApiKey: string, params?: any) {
+export function get<TResponse>(url: string, secretApiKey: string, params?: any) {
   const urlWithParams = generateQuery(url, params);
   return emitRequest<TResponse>(urlWithParams, {
     method: 'GET',