Merge pull request #108 from bengriffin1/bengriffin1-removing-nft

[FIX]: removing unneeded NFT module and related code

Author: bengriffin1

src/core/sdk-exceptions.ts

@@ -63,10 +63,3 @@ export function createExpectedBearerStringError() {
     'Expected argument to be a string in the `Bearer {token}` format.',
   );
 }
-
-export function mintingError() {
-  return new MagicAdminSDKError(
-    ErrorCode.MintingError,
-    'There was an error while minting. Check your contract ID, and token ID if using ERC1155',
-  );
-}

src/core/sdk.ts

@@ -2,7 +2,6 @@ import '../utils/shim';
 import { TokenModule } from '../modules/token';
 import { UsersModule } from '../modules/users';
 import { UtilsModule } from '../modules/utils';
-import { NFTModule } from '../modules/nft';
 import { MagicAdminSDKAdditionalConfiguration } from '../types';
 
 export class MagicAdminSDK {
@@ -25,11 +24,6 @@ export class MagicAdminSDK {
    */
   public readonly utils: UtilsModule;
 
-  /**
-   * Contains utilities for Minting and Delivery of NFTs.
-   */
-  public readonly nft: NFTModule;
-
   constructor(public readonly secretApiKey?: string, options?: MagicAdminSDKAdditionalConfiguration) {
     const endpoint = options?.endpoint ?? 'https://api.magic.link';
     this.apiBaseUrl = endpoint.replace(/\/+$/, '');
@@ -38,6 +32,5 @@ export class MagicAdminSDK {
     this.token = new TokenModule(this);
     this.users = new UsersModule(this);
     this.utils = new UtilsModule(this);
-    this.nft = new NFTModule(this);
   }
 }

src/modules/nft/index.ts

@@ -8,5 +8,4 @@ export enum ErrorCode {
   MalformedTokenError = 'ERROR_MALFORMED_TOKEN',
   ServiceError = 'SERVICE_ERROR',
   ExpectedBearerString = 'EXPECTED_BEARER_STRING',
-  MintingError = 'MINTING_ERROR',
 }

src/types/exception-types.ts

@@ -2,4 +2,3 @@ export * from './didt-types';
 export * from './exception-types';
 export * from './sdk-types';
 export * from './wallet-types';
-export * from './nft-types';

src/types/index.ts

@@ -9,10 +9,6 @@ interface MagicAPIResponse<TData = {}> {
   status?: string | number;
 }
 
-interface Headers {
-  [key: string]: any;
-}
-
 /**
  * Performs a `fetch` to the given URL with the configured `init` object.
  */
@@ -49,15 +45,10 @@ export function post<TBody extends Record<string, string | number | boolean> = {
   url: string,
   secretApiKey: string,
   body: TBody,
-  additionalHeaders?: Headers,
 ) {
-  let headers: Headers = { 'X-Magic-Secret-key': secretApiKey };
-  if (additionalHeaders) {
-    headers = { ...headers, ...additionalHeaders };
-  }
   return emitRequest<TResponse>(url, {
     method: 'POST',
-    headers,
+    headers: { 'X-Magic-Secret-key': secretApiKey },
     body: JSON.stringify(body),
   });
 }

src/types/nft-types.ts

@@ -8,7 +8,7 @@
   https://www.typescriptlang.org/docs/handbook/advanced-types.html#type-guards-and-differentiating-types
  */
 
-import { Claim, MintRequest } from '../types';
+import { Claim } from '../types';
 
 /** Assert `value` is `undefined`. */
 function isUndefined(value: any): value is undefined {
@@ -39,15 +39,3 @@ export function isDIDTClaim(value: any): value is Claim {
     !isNil(value.add)
   );
 }
-
-/** Assert `value` contains all required MintRequest members  */
-export function isMintRequest(value: any): value is MintRequest {
-  return (
-    !isNil(value) &&
-    !isNil(value.data) &&
-    !isNil(value.error_code) &&
-    !isNil(value.message) &&
-    !isNil(value.status) &&
-    !isNil(value.data.request_id)
-  );
-}

src/utils/rest.ts

@@ -28,30 +28,3 @@ test('Successfully POSTs to the given endpoint & stringifies body', async () =>
     },
   ]);
 });
-
-test('Successfully POSTs to the given endpoint and adds JSON header', async () => {
-  const fetchStub = jest.fn().mockImplementation(() => successRes);
-  (fetch as any) = fetchStub;
-
-  await expect(
-    post(
-      'https://example.com/hello/world',
-      API_KEY,
-      { public_address: '0x0123' },
-      { 'Content-Type': 'application/json' },
-    ),
-  ).resolves.toBe('hello world');
-
-  const fetchArguments = fetchStub.mock.calls[0];
-  expect(fetchArguments).toEqual([
-    'https://example.com/hello/world',
-    {
-      method: 'POST',
-      headers: {
-        'X-Magic-Secret-key': API_KEY,
-        'Content-Type': 'application/json',
-      },
-      body: '{"public_address":"0x0123"}',
-    },
-  ]);
-});