Skip to content

Commit b32eff5

Browse files
committed
updated file structure and code style
1 parent dcd48f9 commit b32eff5

40 files changed

+32
-889
lines changed

lib/Exception/ApiConnectionException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@
77
* the SDK can't connect to Magic's servers.
88
*/
99

10-
class ApiConnectionException extends MagicException {}
10+
class ApiConnectionException extends MagicException {}
11+

lib/Exception/ApiException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
* Other api request exception
77
*/
88

9-
class ApiException extends RequestException {}
9+
class ApiException extends RequestException {}
10+

lib/Exception/AuthenticationException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@
77
* the API secret key is missing.
88
*/
99

10-
class AuthenticationException extends RequestException {}
10+
class AuthenticationException extends RequestException {}
11+

lib/Exception/BadRequestException.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,4 @@
99

1010
class BadRequestException extends RequestException {}
1111

12-
13-
12+

lib/Exception/DidTokenException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@
88
* signature mismatch between "proof" and "claim".
99
*/
1010

11-
class DIDTokenException extends MagicException {}
11+
class DIDTokenException extends MagicException {}
12+

lib/Exception/ForbiddenException.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,4 @@
99

1010
class ForbiddenException extends RequestException {}
1111

12-
13-
12+

lib/Exception/MagicException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,5 @@ public function getErrorMessage() {
2222
public function getRepr() {
2323
return __class__ . '(message=' . $this->_message . ')';
2424
}
25-
}
25+
}
26+

lib/Exception/RateLimitException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@
77
* the SDK has sent too many requests to server in a given amount of time.
88
*/
99

10-
class RateLimitException extends RequestException {}
10+
class RateLimitException extends RequestException {}
11+

lib/Exception/RequestException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ public function getRepr() {
4848
', http_code=' . $this->http_code . ')';
4949
}
5050

51-
}
51+
}

lib/HttpClient.php

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,16 @@
1717

1818
class RequestsClient {
1919

20-
public $_retries;
2120
public $_timeout;
22-
public $_backoff_factor;
2321
public $_base_url;
2422
public $_api_secret_key;
2523
public $ch;
2624

27-
public function __construct($api_secret_key, $retries, $timeout, $backoff_factor) {
25+
public function __construct($api_secret_key, $timeout) {
2826

2927
$this->_api_secret_key = $api_secret_key;
3028
$this->_base_url = API_MAGIC_BASE_URL;
31-
$this->_retries = $retries;
3229
$this->_timeout = $timeout;
33-
$this->_backoff_factor = $backoff_factor;
3430
}
3531

3632
public function _setup_curl() {
@@ -182,10 +178,5 @@ public function _parse_and_convert_to_api_response($resp_content, $resp_info, $m
182178
$method
183179
);
184180
}
185-
}
186-
187-
public function _micro_time_count() {
188-
list($usec, $sec) = explode(" ", microtime());
189-
return ((float)$usec + (float)$sec);
190181
}
191-
}
182+
}

lib/Magic.php

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
use MagicAdmin\Exception;
66
use MagicAdmin\Resource;
77

8-
define("RETRIES", 3);
9-
define("TIMEOUT", 10);
10-
define("BACKOFF_FACTOR", 0.02);
8+
define("TIMEOUT", 10);
119

1210
class Magic {
1311

@@ -18,16 +16,10 @@ class Magic {
1816

1917
public function __construct(
2018
$api_secret_key = null,
21-
$retries = RETRIES,
2219
$timeout = TIMEOUT,
23-
$backoff_factor = BACKOFF_FACTOR
24-
) {
25-
$this->_set_api_secret_key($api_secret_key);
26-
$this->token = new \MagicAdmin\Resource\Token();
27-
$this->user = new \MagicAdmin\Resource\User($this->api_secret_key, $retries, $timeout, $backoff_factor);
28-
}
29-
30-
public function _set_api_secret_key($api_secret_key) {
20+
) {
3121
$this->api_secret_key = $api_secret_key;
32-
}
33-
}
22+
$this->token = new \MagicAdmin\Resource\Token();
23+
$this->user = new \MagicAdmin\Resource\User($this->api_secret_key, $timeout);
24+
}
25+
}

lib/Resource/User.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ class User {
1212
public $request_client;
1313
public $token;
1414

15-
public function __construct($api_secret_key, $retries, $timeout, $backoff_factor) {
15+
public function __construct($api_secret_key, $timeout) {
1616
$this->token = new Token();
17-
$this->request_client = new \MagicAdmin\RequestsClient($api_secret_key, $retries, $timeout, $backoff_factor);
17+
$this->request_client = new \MagicAdmin\RequestsClient($api_secret_key, $timeout);
1818
}
1919

2020
public function get_metadata_by_issuer($issuer) {

lib/Response.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ public function __construct($content, $resp_data, $status_code) {
1212
$this->status_code = $status_code;
1313
$this->data = $resp_data;
1414
}
15-
}
15+
}

tests/magic-admin-php/.editorconfig

Lines changed: 0 additions & 20 deletions
This file was deleted.

tests/magic-admin-php/.gitignore

Lines changed: 0 additions & 31 deletions
This file was deleted.

tests/magic-admin-php/LICENSE

Lines changed: 0 additions & 21 deletions
This file was deleted.

tests/magic-admin-php/README.md

Lines changed: 0 additions & 112 deletions
This file was deleted.

tests/magic-admin-php/VERSION

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/magic-admin-php/composer.json

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)