Add ability to open PR diff as editor in VS Code

Author: magicus

README.md

@@ -45,6 +45,13 @@ This extension contributes the following commands:
 
 ## Release Notes
 
+### 2.0.2
+
+Add ability to open the PR diff as an editor in VS Code. I highly recommend
+complementing this functionality with a plugin for viewing diff files, such as
+[Diff Viewer](
+https://marketplace.visualstudio.com/items?itemName=caponetto.vscode-diff-viewer).
+
 ### 2.0.1
 
 Added "Collapse all" button to tree views.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "openjdk-devel",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "displayName": "OpenJDK Development",
   "description": "Support for OpenJDK developers",
   "publisher": "magicus",

src/extension.ts

@@ -2,12 +2,17 @@ import * as vscode from 'vscode';
 
 import { GitHubProvider } from './github';
 import { JbsProvider } from './jbs';
+import { DownloadableContentProvider } from './downloading';
+
+export const downloadableContentProvider = new DownloadableContentProvider('openjdk-dev-dl');
 
 // this method is called when your extension is activated
 // your extension is activated the very first time the command is executed
 export function activate(context: vscode.ExtensionContext): void {
   console.log('Loading extension "OpenJDK Development"');
 
+  downloadableContentProvider.register(context);
+
   const githubProvider = new GitHubProvider();
   vscode.window.createTreeView('gitHubIntegration', {
     treeDataProvider: githubProvider,

src/github.ts

@@ -3,6 +3,7 @@ import * as vscode from 'vscode';
 
 import { UpdatableProvider, UpdatableTreeItem } from './updatable';
 import { JsonDownloader } from './downloading';
+import { downloadableContentProvider } from './extension';
 
 class GitHubUpdatableDownloader extends JsonDownloader<GitHubTreeItem> {
   public static gitHubApiBase: string = 'https://api.github.com/';
@@ -253,21 +254,27 @@ class PRTreeItem extends GitHubTreeItem {
     const prUrlBase = `https://github.com/${repo}/pull/${prNumber}`;
 
     this.generated.push(new GitHubLeafTreeItem(`${repo}#${prNumber} by @${author}`, 'goto' + id,
-      'github-overview.svg', prUrlBase, provider));
+      'github-overview.svg', prUrlBase + '/files', provider));
 
     const descItem = new GitHubLeafTreeItem(description.replace(/\s+/g, ' '), 'desc' + id,
       'github-conversation.svg', prUrlBase, provider);
     descItem.tooltip = new vscode.MarkdownString(description);
     this.generated.push(descItem);
 
+    var mainJbsIssue = undefined;
     for (const jbsIssue of jbsIssues) {
+      if (mainJbsIssue === undefined) {
+        mainJbsIssue = jbsIssue;
+      }
       this.generated.push(new GitHubLeafTreeItem(jbsIssue, 'jbs' + id + '-' + jbsIssue,
         'github-bug.svg', 'https://bugs.openjdk.java.net/browse/' + jbsIssue, provider));
     }
 
     // Diff description must be complemented from prUrl, which can only be done later
+    const editorViewUrl = downloadableContentProvider.getDownloadableUrl(prUrlBase + '.diff',
+      mainJbsIssue + '.diff');
     this.diffItem = new GitHubLeafTreeItem('Diff', 'diff' + id, 'github-diff.svg',
-      prUrlBase + '/files', provider);
+      editorViewUrl, provider);
     this.generated.push(this.diffItem);
 
     if (tags) {