Don't hardcode username

Author: magicus

package.json

@@ -45,6 +45,11 @@
     "configuration": {
       "title": "OpenJDK Development",
       "properties": {
+        "openjdkDevel.github.username": {
+          "type": "string",
+          "default": "",
+          "markdownDescription": "Your GitHub user name"
+        },
         "openjdkDevel.github.apiToken": {
           "type": "string",
           "default": "",
@@ -68,7 +73,13 @@
         "command": "openjdkDevel.setGithubToken",
         "title": "Setup GitHub API Token",
         "category": "JDK Development"
+      },
+      {
+        "command": "openjdkDevel.setGithubUsername",
+        "title": "Setup GitHub username",
+        "category": "JDK Development"
       }
+
     ],
     "menus": {
       "commandPalette": [
@@ -108,7 +119,13 @@
         "view": "gitHubIntegration",
         "contents": "In order to use the GitHub integration, you need to specify a GitHub API token.\n[Setup GitHub token](command:openjdkDevel.setGithubToken)",
         "when": "config.openjdkDevel.github.apiToken == ''"
+      },
+      {
+        "view": "gitHubIntegration",
+        "contents": "In order to use the GitHub integration, you need to specify a GitHub user name.\n[Setup GitHub user name](command:openjdkDevel.setGithubUsername)",
+        "when": "config.openjdkDevel.github.username == ''"
       }
+
     ]
   },
   "scripts": {

src/extension.ts

@@ -18,10 +18,17 @@ export function activate(context: vscode.ExtensionContext) {
     vscode.commands.executeCommand('workbench.action.openSettings', 'openjdkDevel.github.apiToken');
   }));
 
+  context.subscriptions.push(vscode.commands.registerCommand('openjdkDevel.setGithubUsername', () => {
+    vscode.commands.executeCommand('workbench.action.openSettings', 'openjdkDevel.github.username');
+  }));
+
   vscode.workspace.onDidChangeConfiguration(event => {
     if (event.affectsConfiguration('openjdkDevel.github.apiToken')) {
       githubProvider.userRefresh();
     }
+    if (event.affectsConfiguration('openjdkDevel.github.username')) {
+      githubProvider.userRefresh();
+    }
   });
 }
 

src/github.ts

@@ -40,11 +40,14 @@ export class GitHubProvider implements vscode.TreeDataProvider<GitHubTreeItem> {
   private rootNodes: GitHubTreeItem[] = [];
 
   constructor() {
-    const token = vscode.workspace.getConfiguration('openjdkDevel').get('github.apiToken', '');
-    if (token === '') {
+    if (!this.verifySettings()) {
       // An empty root set will trigger the welcome view
       return;
     }
+    this.setupTree();
+  }
+
+  setupTree() {
     const alerts = new AlertsRootItem('Notifications', this.onDidChangeTreeDataEmitter);
     this.rootNodes.push(alerts);
     const prs = new PRsRootItem('My Pull Requests', this.onDidChangeTreeDataEmitter);
@@ -62,8 +65,27 @@ export class GitHubProvider implements vscode.TreeDataProvider<GitHubTreeItem> {
     return element.getChildrenAny();
   }
 
+  verifySettings(): boolean {
+    const token = vscode.workspace.getConfiguration('openjdkDevel').get('github.apiToken', '');
+    const username = vscode.workspace.getConfiguration('openjdkDevel').get('github.username', '');
+    return token !== '' && username !== '';
+  }
+
   userRefresh() {
+    if (!this.verifySettings()) {
+      // An empty root set will trigger the welcome view
+      // Yes, setting length to 0 is valid javascript...
+      this.rootNodes.length = 0;
+      this.signalNeedForScreenRefresh();
+      return;
+    }
+
+    if (this.rootNodes.length === 0) {
+      this.setupTree();
+    }
+
     this.rootNodes.forEach(node => node.reloadFromWeb(true));
+    this.signalNeedForScreenRefresh();
   }
 
   signalNeedForScreenRefresh(item?: GitHubTreeItem): void {
@@ -165,8 +187,9 @@ class PRsRootItem extends GitHubTreeItem {
   }
 
   protected loadChildrenArrayFromWeb(): Promise<GitHubTreeItem[]> {
+    const username = vscode.workspace.getConfiguration('openjdkDevel').get('github.username', '');
     return GitHubProvider.getGHjson(GitHubProvider.apiBase +
-      'search/issues?q=is:open+is:pr+archived:false+repo:openjdk/jdk+author:magicus',
+      'search/issues?q=is:open+is:pr+archived:false+repo:openjdk/jdk+author:' + username,
     (json: any, resolveJson: any, rejectJson: any) => {
       const items = json.items;
       const newPRs: PRTreeItem[] = [];