Skip to content

Commit 99ee8f9

Browse files
psychedelicioushipsterusername
authored andcommitted
feat(installer): remove vX-latest from tag_release
Also update RELEASE.md accordingly, and make the release.yml workflow match on `v*` tags.
1 parent 50e58ff commit 99ee8f9

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Release
33
on:
44
push:
55
tags:
6-
- 'v*.*.*'
6+
- 'v*'
77
workflow_dispatch:
88
inputs:
99
skip_code_checks:

docs/RELEASE.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,14 @@ While the release workflow does not include end-to-end tests, it does pause befo
1515

1616
The `release.yml` workflow runs a number of jobs to handle code checks, tests, build and publish on PyPI.
1717

18-
It is triggered on **tag push**, when the tag matches `v*.*.*`. It doesn't matter if you've prepped a release branch like `release/v3.5.0` or are releasing from `main` - it works the same.
18+
It is triggered on **tag push**, when the tag matches `v*`. It doesn't matter if you've prepped a release branch like `release/v3.5.0` or are releasing from `main` - it works the same.
1919

2020
> Because commits are reference-counted, it is safe to create a release branch, tag it, let the workflow run, then delete the branch. So long as the tag exists, that commit will exist.
2121
2222
### Triggering the Workflow
2323

2424
Run `make tag-release` to tag the current commit and kick off the workflow.
2525

26-
This script actually makes two tags - one for the specific version, and a `vX-latest` tag that changes with each release.
27-
28-
Because the release workflow only triggers on the pattern `v*.*.*`, the workflow will only run once when running this script.
29-
3026
The release may also be run [manually].
3127

3228
### Workflow Jobs and Process

installer/tag_release.sh

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,13 @@ VERSION=$(
2626
python3 -c "from invokeai.version import __version__ as version; print(version)"
2727
)
2828
PATCH=""
29-
MAJOR_VERSION=$(echo $VERSION | sed 's/\..*$//')
3029
VERSION="v${VERSION}${PATCH}"
31-
LATEST_TAG="v${MAJOR_VERSION}-latest"
3230

3331
if does_tag_exist $VERSION; then
3432
echo -e "${BCYAN}${VERSION}${RESET} already exists:"
3533
git_show_ref tags/$VERSION
3634
echo
3735
fi
38-
if does_tag_exist $LATEST_TAG; then
39-
echo -e "${BCYAN}${LATEST_TAG}${RESET} already exists:"
40-
git_show_ref tags/$LATEST_TAG
41-
echo
42-
fi
4336

4437
echo -e "${BGREEN}HEAD${RESET}:"
4538
git_show
@@ -49,7 +42,7 @@ echo -e "${BGREEN}git remote -v${RESET}:"
4942
git remote -v
5043
echo
5144

52-
echo -e -n "Create tags ${BCYAN}${VERSION}${RESET} and ${BCYAN}${LATEST_TAG}${RESET} @ ${BGREEN}HEAD${RESET}, ${RED}deleting existing tags on origin remote${RESET}? "
45+
echo -e -n "Create tags ${BCYAN}${VERSION}${RESET} @ ${BGREEN}HEAD${RESET}, ${RED}deleting existing tags on origin remote${RESET}? "
5346
read -e -p 'y/n [n]: ' input
5447
RESPONSE=${input:='n'}
5548
if [ "$RESPONSE" == 'y' ]; then
@@ -63,12 +56,6 @@ if [ "$RESPONSE" == 'y' ]; then
6356
exit -1
6457
fi
6558

66-
echo -e "Deleting ${BCYAN}${LATEST_TAG}${RESET} tag on origin remote..."
67-
git push origin :refs/tags/$LATEST_TAG
68-
69-
echo -e "Tagging ${BGREEN}HEAD${RESET} with ${BCYAN}${LATEST_TAG}${RESET} locally..."
70-
git tag -fa $LATEST_TAG
71-
7259
echo -e "Pushing updated tags to origin remote..."
7360
git push origin --tags
7461
fi

0 commit comments

Comments
 (0)