servo: Merge #16473 - Upgrade to rustc 1.18.0-nightly (5f13a3b54 2017-04-15) (from servo:rustup); r=emilio

This version enables [struct field reordering][1] which brings the size of the types for specified values of some CSS properties under the threshold such that they shouldn’t be boxed anymore, making unit tests fail.

Simply unboxing them moves the test failure to Stylo’s unit tests, since the stable compiler used in that case does not do field re-ordering. Therefore, we manually reorder a couple fields to effectively bring this optimization to older compilers for a few specific types.

[1]: rust-lang/rust#40377

Source-Repo: https://github.com/servo/servo
Source-Revision: c453e2ef89b32798dabbb23b22cfd5a72dddf6a5

UltraBlame original commit: 55519369af2b2a65f2a5c2275522a8b1dc014953

Author: marco-c

servo/components/script/dom/element.rs

@@ -5322,11 +5322,6 @@ PropertyDeclaration
 :
 BorderTopWidth
 (
-Box
-:
-:
-new
-(
 width_value
 .
 clone
@@ -5335,7 +5330,6 @@ clone
 )
 )
 )
-)
 ;
 hints
 .
@@ -5349,11 +5343,6 @@ PropertyDeclaration
 :
 BorderLeftWidth
 (
-Box
-:
-:
-new
-(
 width_value
 .
 clone
@@ -5362,7 +5351,6 @@ clone
 )
 )
 )
-)
 ;
 hints
 .
@@ -5376,11 +5364,6 @@ PropertyDeclaration
 :
 BorderBottomWidth
 (
-Box
-:
-:
-new
-(
 width_value
 .
 clone
@@ -5389,7 +5372,6 @@ clone
 )
 )
 )
-)
 ;
 hints
 .
@@ -5403,16 +5385,10 @@ PropertyDeclaration
 :
 BorderRightWidth
 (
-Box
-:
-:
-new
-(
 width_value
 )
 )
 )
-)
 ;
 }
 }

servo/components/style/properties/longhand/border.mako.rs

@@ -459,11 +459,6 @@ side
 -
 width
 "
-boxed
-=
-"
-True
-"
 animation_type
 =
 "

servo/components/style/properties/longhand/box.mako.rs

@@ -15578,9 +15578,6 @@ extra_prefixes
 moz
 webkit
 "
-boxed
-=
-True
 creates_stacking_context
 =
 True

servo/components/style/properties/longhand/column.mako.rs

@@ -147,9 +147,6 @@ extra_prefixes
 "
 moz
 "
-boxed
-=
-True
 animation_type
 =
 "
@@ -321,9 +318,6 @@ moz
 experimental
 =
 True
-boxed
-=
-True
 animation_type
 =
 "
@@ -455,11 +449,6 @@ products
 "
 gecko
 "
-boxed
-=
-"
-True
-"
 animation_type
 =
 "

servo/components/style/properties/longhand/inherited_text.mako.rs

@@ -3323,11 +3323,6 @@ letter
 -
 spacing
 "
-boxed
-=
-"
-True
-"
 animation_type
 =
 "
@@ -9147,9 +9142,6 @@ products
 "
 gecko
 "
-boxed
-=
-True
 animation_type
 =
 "
@@ -9371,11 +9363,6 @@ stroke
 -
 width
 "
-boxed
-=
-"
-True
-"
 animation_type
 =
 "

servo/components/style/values/computed/length.rs

@@ -411,9 +411,9 @@ Length
 :
 Calc
 (
+range
 ref
 calc
-range
 )
 =
 >

servo/components/style/values/specified/length.rs

@@ -3921,11 +3921,11 @@ calc
 notation
 Calc
 (
+AllowedLengthType
 Box
 <
 CalcLengthOrPercentage
 >
-AllowedLengthType
 )
 }
 impl
@@ -3999,9 +3999,9 @@ Length
 :
 Calc
 (
+_
 ref
 calc
-_
 )
 =
 >
@@ -4071,9 +4071,9 @@ Length
 :
 Calc
 (
+_
 ref
 calc
-_
 )
 =
 >
@@ -6591,14 +6591,14 @@ Length
 :
 Calc
 (
+num_context
 Box
 :
 :
 new
 (
 calc
 )
-num_context
 )
 }
 )
@@ -8516,8 +8516,8 @@ Length
 :
 Calc
 (
-l
 _
+l
 )
 =
 >

servo/ports/geckolib/glue.rs

@@ -11069,11 +11069,6 @@ into
 BorderTopWidth
 =
 >
-Box
-:
-:
-new
-(
 BorderWidth
 :
 :
@@ -11085,15 +11080,9 @@ into
 (
 )
 )
-)
 BorderRightWidth
 =
 >
-Box
-:
-:
-new
-(
 BorderWidth
 :
 :
@@ -11105,15 +11094,9 @@ into
 (
 )
 )
-)
 BorderBottomWidth
 =
 >
-Box
-:
-:
-new
-(
 BorderWidth
 :
 :
@@ -11125,15 +11108,9 @@ into
 (
 )
 )
-)
 BorderLeftWidth
 =
 >
-Box
-:
-:
-new
-(
 BorderWidth
 :
 :
@@ -11145,7 +11122,6 @@ into
 (
 )
 )
-)
 MarginTop
 =
 >

servo/rust-commit-hash

@@ -1 +1 @@
-474f7a91eec8cba83b7eb7a578a7adb70614f877
+5f13a3b540ab6024665322d716e487c800645f24