⚠️ No Changeset found

Latest commit: 30567cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	30567cb
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/67e72f363ad50a0008f98ce7
😎 Deploy Preview	https://deploy-preview-6435--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6435

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6435

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6435

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6435

commit: 30567cb

The latest updates on your projects. Learn more about Argos notifications ↗︎

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (936d107) to head (30567cb).
Report is 82 commits behind head on develop.

@@           Coverage Diff           @@
##           develop   #6435   +/-   ##
=======================================
  Coverage     3.86%   3.86%           
=======================================
  Files          412     412           
  Lines        43189   43189           
  Branches       664     664           
=======================================
  Hits          1670    1670           
  Misses       41519   41519           

The Argos visual diffs are expected due to the fix for subgraph direction inheritance. Subgraphs now inherit the global graph direction instead of defaulting to TD, which changes their layout. Please accept these changes in Argos or mark them as expected.

@ashishjain0512 can you please review the argos changes ?

@nour0205 I looked at the PR and I think this is a welcome change, and agree that there can we some scenarios where the users would want same direction throughout the flowchart.

However, it was a conscious decision to have it implemented in the current state, where each nested layer of sub-graph alternates the directions to utilize space and let the diagram grow both vertically and horizontally.

Also, we believe any new changes should have a minimum impact on existing diagrams, and this change could impact all flowcharts with sub-graph.

I propose we add a flowchart config option inheritDir which when enabled will inherit and apply same direction across.

Once this is driven via configuration, and you add some rendering and spec test around it, we will be happy to merge.

If you have questions, you can reach out here.

CC: @knsv

Closing this in favor of your new PR #6470