Update hasDynamicName to take well known symbols into account

Author: JsonFreeman

src/compiler/utilities.ts

@@ -843,7 +843,9 @@ module ts {
      *      Symbol.
      */
     export function hasDynamicName(declaration: Declaration): boolean {
-        return declaration.name && declaration.name.kind === SyntaxKind.ComputedPropertyName;
+        return declaration.name &&
+            declaration.name.kind === SyntaxKind.ComputedPropertyName &&
+            !isWellKnownSymbolSyntactically((<ComputedPropertyName>declaration.name).expression);
     }
 
     export function isWellKnownSymbolSyntactically(node: Node): boolean {

tests/baselines/reference/parserSymbolProperty1.errors.txt

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty1.ts ===
+interface I {
+>I : I
+
+    [Symbol.iterator]: string;
+>Symbol.iterator : Symbol
+>Symbol : SymbolConstructor
+>iterator : Symbol
+}

tests/baselines/reference/parserSymbolProperty1.types

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty2.ts ===
+interface I {
+>I : I
+
+    [Symbol.unscopables](): string;
+>Symbol.unscopables : Symbol
+>Symbol : SymbolConstructor
+>unscopables : Symbol
+}

tests/baselines/reference/parserSymbolProperty2.errors.txt

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty3.ts ===
+declare class C {
+>C : C
+
+    [Symbol.unscopables](): string;
+>Symbol.unscopables : Symbol
+>Symbol : SymbolConstructor
+>unscopables : Symbol
+}

tests/baselines/reference/parserSymbolProperty2.types

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty4.ts ===
+declare class C {
+>C : C
+
+    [Symbol.isRegExp]: string;
+>Symbol.isRegExp : Symbol
+>Symbol : SymbolConstructor
+>isRegExp : Symbol
+}

tests/baselines/reference/parserSymbolProperty3.errors.txt

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty5.ts ===
+class C {
+>C : C
+
+    [Symbol.isRegExp]: string;
+>Symbol.isRegExp : Symbol
+>Symbol : SymbolConstructor
+>isRegExp : Symbol
+}

tests/baselines/reference/parserSymbolProperty3.types

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty6.ts ===
+class C {
+>C : C
+
+    [Symbol.toStringTag]: string = "";
+>Symbol.toStringTag : Symbol
+>Symbol : SymbolConstructor
+>toStringTag : Symbol
+}

tests/baselines/reference/parserSymbolProperty4.errors.txt

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty7.ts ===
+class C {
+>C : C
+
+    [Symbol.toStringTag](): void { }
+>Symbol.toStringTag : Symbol
+>Symbol : SymbolConstructor
+>toStringTag : Symbol
+}

tests/baselines/reference/parserSymbolProperty4.types

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty8.ts ===
+var x: {
+>x : {}
+
+    [Symbol.toPrimitive](): string
+>Symbol.toPrimitive : Symbol
+>Symbol : SymbolConstructor
+>toPrimitive : Symbol
+}

tests/baselines/reference/parserSymbolProperty5.errors.txt

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/parser/ecmascript6/Symbols/parserSymbolProperty9.ts ===
+var x: {
+>x : {}
+
+    [Symbol.toPrimitive]: string
+>Symbol.toPrimitive : Symbol
+>Symbol : SymbolConstructor
+>toPrimitive : Symbol
+}