Skip to content

Suggest imports to self-reference a package by its name when it has an exports field #54080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks done
emmatown opened this issue May 1, 2023 · 1 comment
Open
5 tasks done
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Auto-import Suggestion An idea for TypeScript

Comments

@emmatown
Copy link
Contributor

emmatown commented May 1, 2023

Suggestion

πŸ” Search Terms

Package self reference auto import

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Node.js supports self-referencing a package using its name when it has an exports field. Note this is distinct from self-referencing a package working in some monorepo setups where there are symlinks from node_modules to the packages. This doesn't rely on any symlinks, it looks up to the nearest package.json and if it has a name and exports field, importing that package name resolves there. This works correctly with moduleResolution nodenext/bundler but TypeScript doesn't suggest auto-imports to the package name or have completions to the package name in import specifiers, it would be nice if it did.

This is essentially the same request as #52460 but about a package's own exports rather than its imports.

This is also sort of a request for the opposite behaviour than requested in #26044 except that this is specifically only about packages that have an exports field where TypeScript is configured to use the exports field. I don't think this really conflicts with that issue since the problem there is that without exports, it can lead to imports like my-pkg/src/something which you don't want but since package self-referencing like this requires an exports field, imports like that wouldn't be allowed.

πŸ“ƒ Motivating Example

Let's say you have a package that looks like this:

// package.json
{
  "name": "my-package",
  "type": "module",
  "exports": "./index.js"
}
// index.js
export function doSomething() {}
// index.d.ts
export declare function doSomething(): void;

And you'd like to write tests that reference the package name so it's easy to see that the tests only use the package's public API specified in exports, you can already do this and it will correctly compile with moduleResolution bundler/nodenext but with this feature, the suggested import would be to my-package rather than ./index.js.

// index.test.ts
import { doSomething } from 'my-package';

// some tests...

πŸ’» Use Cases

As mentioned above, being able to easily write tests that only use a package's public API in the same way that users would use it via the package name without having to work around auto-import by changing the import after auto-import suggests a relative path.

@RyanCavanaugh RyanCavanaugh added Suggestion An idea for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Auto-import labels May 2, 2023
@smallmain
Copy link

need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Auto-import Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants