From 7d0d90e24c49e45427776597f1e0ae31fe571764 Mon Sep 17 00:00:00 2001 From: "D Kodanda Ramudu (LTIMINDTREE LIMITED)" Date: Thu, 3 Apr 2025 09:48:41 +0530 Subject: [PATCH 1/3] added error for override parameters undefined issue --- .../operations/Utils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts b/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts index 4296265b5a82..52d55ab1c746 100644 --- a/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts +++ b/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts @@ -370,7 +370,8 @@ class Utils { try { overrideParameter.value = this.castToType(overrideParameter.value, template.parameters[overrideParameter.name].type); - } catch (error) { + } catch (error) { + tl.error("The provided metadata file " + taskParameters.csmFile + " is missing metadata of parameter " + overrideParameter.name); console.log(tl.loc("ErrorWhileParsingParameter", overrideParameter.name, error.toString())); } parameters[overrideParameter.name] = { From 79dbd4baa3eaeb22380a70fad0c78407c9fb02b1 Mon Sep 17 00:00:00 2001 From: "D Kodanda Ramudu (LTIMINDTREE LIMITED)" Date: Thu, 3 Apr 2025 12:35:33 +0530 Subject: [PATCH 2/3] modified error as warning --- .../operations/Utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts b/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts index 52d55ab1c746..94e24bc25c95 100644 --- a/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts +++ b/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts @@ -371,7 +371,7 @@ class Utils { try { overrideParameter.value = this.castToType(overrideParameter.value, template.parameters[overrideParameter.name].type); } catch (error) { - tl.error("The provided metadata file " + taskParameters.csmFile + " is missing metadata of parameter " + overrideParameter.name); + tl.warning("The provided metadata file " + taskParameters.csmFile + " is missing metadata of parameter " + overrideParameter.name); console.log(tl.loc("ErrorWhileParsingParameter", overrideParameter.name, error.toString())); } parameters[overrideParameter.name] = { From 2c19932ef22b2d4e5585f8cfe5f657a927363567 Mon Sep 17 00:00:00 2001 From: "D Kodanda Ramudu (LTIMINDTREE LIMITED)" Date: Thu, 3 Apr 2025 16:47:56 +0530 Subject: [PATCH 3/3] modified error message for override parameter undefined issue --- .../Strings/resources.resjson/en-US/resources.resjson | 2 +- .../operations/Utils.ts | 3 +-- Tasks/AzureResourceManagerTemplateDeploymentV3/task.json | 4 ++-- Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Tasks/AzureResourceManagerTemplateDeploymentV3/Strings/resources.resjson/en-US/resources.resjson b/Tasks/AzureResourceManagerTemplateDeploymentV3/Strings/resources.resjson/en-US/resources.resjson index 655eb258615f..e51b2c232873 100644 --- a/Tasks/AzureResourceManagerTemplateDeploymentV3/Strings/resources.resjson/en-US/resources.resjson +++ b/Tasks/AzureResourceManagerTemplateDeploymentV3/Strings/resources.resjson/en-US/resources.resjson @@ -70,7 +70,7 @@ "loc.messages.EncodingNotSupported": "Encoding of the file '%s' is '%s' which is not supported. Supported file encodings are ['utf-8', 'utf-16le']", "loc.messages.CouldNotDetectEncoding": "Could not detect encoding of file '%s'", "loc.messages.DetectedFileEncoding": "The detected encoding for file '%s' is '%s'", - "loc.messages.ErrorWhileParsingParameter": "There was an error while overriding '%s' parameter because of '%s', make sure it follows JavaScript Object Notation (JSON)", + "loc.messages.ErrorWhileParsingParameter": "The provided metadata file '%s' is missing metadata of parameter '%s'", "loc.messages.TemplateFilePatternMatchingMoreThanOneFile": "Found multiple files matching template file pattern: %s", "loc.messages.TemplateParameterFilePatternMatchingMoreThanOneFile": "Found multiple files matching template parameters file pattern: %s", "loc.messages.TemplateFilePatternMatchingNoFile": "Could not find any file matching the template file pattern", diff --git a/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts b/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts index 94e24bc25c95..2fedf987b90a 100644 --- a/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts +++ b/Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts @@ -371,8 +371,7 @@ class Utils { try { overrideParameter.value = this.castToType(overrideParameter.value, template.parameters[overrideParameter.name].type); } catch (error) { - tl.warning("The provided metadata file " + taskParameters.csmFile + " is missing metadata of parameter " + overrideParameter.name); - console.log(tl.loc("ErrorWhileParsingParameter", overrideParameter.name, error.toString())); + tl.error(tl.loc("ErrorWhileParsingParameter", taskParameters.csmFile, overrideParameter.name)); } parameters[overrideParameter.name] = { value: overrideParameter.value diff --git a/Tasks/AzureResourceManagerTemplateDeploymentV3/task.json b/Tasks/AzureResourceManagerTemplateDeploymentV3/task.json index 44dbddcc7478..a1c387039926 100644 --- a/Tasks/AzureResourceManagerTemplateDeploymentV3/task.json +++ b/Tasks/AzureResourceManagerTemplateDeploymentV3/task.json @@ -15,7 +15,7 @@ "version": { "Major": 3, "Minor": 252, - "Patch": 2 + "Patch": 3 }, "demands": [], "minimumAgentVersion": "2.119.1", @@ -310,7 +310,7 @@ "EncodingNotSupported": "Encoding of the file '%s' is '%s' which is not supported. Supported file encodings are ['utf-8', 'utf-16le']", "CouldNotDetectEncoding": "Could not detect encoding of file '%s'", "DetectedFileEncoding": "The detected encoding for file '%s' is '%s'", - "ErrorWhileParsingParameter": "There was an error while overriding '%s' parameter because of '%s', make sure it follows JavaScript Object Notation (JSON)", + "ErrorWhileParsingParameter": "The provided metadata file '%s' is missing metadata of parameter '%s'", "TemplateFilePatternMatchingMoreThanOneFile": "Found multiple files matching template file pattern: %s", "TemplateParameterFilePatternMatchingMoreThanOneFile": "Found multiple files matching template parameters file pattern: %s", "TemplateFilePatternMatchingNoFile": "Could not find any file matching the template file pattern", diff --git a/Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json b/Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json index 33019282e614..a8ad49944ab8 100644 --- a/Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json +++ b/Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json @@ -15,7 +15,7 @@ "version": { "Major": 3, "Minor": 252, - "Patch": 2 + "Patch": 3 }, "demands": [], "minimumAgentVersion": "2.119.1",