Skip to content

Commit 8c6aa50

Browse files
authored
Merge branch 'main' into meta_updates
2 parents b70ee68 + b5660a0 commit 8c6aa50

File tree

183 files changed

+176
-8021
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

183 files changed

+176
-8021
lines changed

libraries/botbuilder-applicationinsights/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
]
1313
TESTS_REQUIRES = [
1414
"aiounittest==1.3.0",
15-
"django==3.2.14", # For samples
15+
"django==3.2.16", # For samples
1616
"djangorestframework==3.10.3", # For samples
1717
"flask==1.1.1", # For samples
1818
]

libraries/botbuilder-core/requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ botframework-connector==4.15.0
33
botbuilder-schema==4.15.0
44
botframework-streaming==4.15.0
55
requests==2.27.1
6-
PyJWT==1.5.3
6+
PyJWT==2.4.0
77
cryptography==3.3.2
88
aiounittest==1.3.0

libraries/botbuilder-dialogs/botbuilder/dialogs/memory/dialog_state_manager.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,10 @@ def try_get_value(
290290
# TODO: HACK to support .First() retrieval on turn.recognized.entities.foo, replace with Expressions once
291291
# expressions ship
292292
first = ".FIRST()"
293-
i_first = path.upper().rindex(first)
293+
try:
294+
i_first = path.upper().rindex(first)
295+
except ValueError:
296+
i_first = -1
294297
if i_first >= 0:
295298
remaining_path = path[i_first + len(first) :]
296299
path = path[0:i_first]

libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt_culture_models.py

+1
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ def get_supported_cultures(cls) -> List[PromptCultureModel]:
174174
"""
175175
return [
176176
cls.Chinese,
177+
cls.German,
177178
cls.Dutch,
178179
cls.English,
179180
cls.French,

libraries/botbuilder-dialogs/requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ botframework-connector==4.15.0
33
botbuilder-schema==4.15.0
44
botbuilder-core==4.15.0
55
requests==2.27.1
6-
PyJWT==1.5.3
6+
PyJWT==2.4.0
77
cryptography==3.3.2
88
aiounittest==1.3.0

libraries/botframework-connector/botframework/connector/auth/emulator_validation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def is_token_from_emulator(auth_header: str) -> bool:
6363
bearer_token = auth_header.split(" ")[1]
6464

6565
# Parse the Big Long String into an actual token.
66-
token = jwt.decode(bearer_token, verify=False)
66+
token = jwt.decode(bearer_token, options={"verify_signature": False})
6767
if not token:
6868
return False
6969

libraries/botframework-connector/botframework/connector/auth/jwt_token_extractor.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ async def get_identity(
6868
raise error
6969

7070
def _has_allowed_issuer(self, jwt_token: str) -> bool:
71-
decoded = jwt.decode(jwt_token, verify=False)
71+
decoded = jwt.decode(jwt_token, options={"verify_signature": False})
7272
issuer = decoded.get("iss", None)
7373
if issuer in self.validation_parameters.issuer:
7474
return True
@@ -111,6 +111,7 @@ async def _validate_token(
111111
metadata.public_key,
112112
leeway=self.validation_parameters.clock_tolerance,
113113
options=options,
114+
algorithms=["RS256"],
114115
)
115116

116117
claims = ClaimsIdentity(decoded_payload, True)

libraries/botframework-connector/botframework/connector/auth/skill_validation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def is_skill_token(auth_header: str) -> bool:
5555
bearer_token = auth_header.split(" ")[1]
5656

5757
# Parse the Big Long String into an actual token.
58-
token = jwt.decode(bearer_token, verify=False)
58+
token = jwt.decode(bearer_token, options={"verify_signature": False})
5959
return SkillValidation.is_skill_claim(token)
6060

6161
@staticmethod
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
msrest==0.6.*
22
botbuilder-schema==4.15.0
33
requests==2.27.1
4-
PyJWT==1.5.3
4+
PyJWT==2.4.0
55
cryptography==3.3.2
66
msal==1.*

libraries/botframework-connector/setup.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
VERSION = os.environ["packageVersion"] if "packageVersion" in os.environ else "4.15.0"
99
REQUIRES = [
1010
"msrest==0.6.*",
11-
"requests>=2.23.0,<2.26",
12-
"PyJWT>=1.5.3,<2.0.0",
11+
# "requests>=2.23.0,<2.26",
12+
"PyJWT>=2.4.0",
1313
"botbuilder-schema==4.15.0",
1414
"msal==1.*",
1515
]

libraries/botframework-streaming/setup.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
VERSION = os.environ["packageVersion"] if "packageVersion" in os.environ else "4.15.0"
88
REQUIRES = [
9-
"botbuilder-schema>=4.12.0",
10-
"botframework-connector>=4.12.0",
9+
"botbuilder-schema==4.15.0",
10+
"botframework-connector==4.15.0",
1111
]
1212

1313
root = os.path.abspath(os.path.dirname(__file__))

0 commit comments

Comments
 (0)