Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

replace memmap crate #363

Closed
bmc-msft opened this issue Dec 2, 2020 · 5 comments · Fixed by #428
Closed

replace memmap crate #363

bmc-msft opened this issue Dec 2, 2020 · 5 comments · Fixed by #428
Assignees
@ranweiler
Labels
bug Something isn't working

Comments

@bmc-msft
Copy link
Contributor

bmc-msft commented Dec 2, 2020

As identified by cargo audit in our CICD, the memmap crate is apparently abandoned. We should investigate replacing it with a maintained alternative.

Reference: rustsec/advisory-db#359
@bmc-msft bmc-msft added the bug Something isn't working label Dec 2, 2020
@ghost ghost added the Needs: triage label Dec 2, 2020
@bmc-msft
Copy link
Contributor Author

bmc-msft commented Dec 2, 2020

We use memmap in the coverage and debugger crates. @ranweiler or @lzybkr, since you are active in this code, can one of you investigate this?

@bmc-msft bmc-msft mentioned this issue Dec 2, 2020
Merged
@ranweiler
Copy link
Member

@bmc-msft, yes. Per this discussion, the mapr crate may be a reasonable alternative. Will poke around.

@ranweiler
Copy link
Member

At first glance: I think it would be better to push towards getting memmap itself maintained again (which is something I'd be interested in helping with). The crate itself is relatively small. mapr seems to be primarily forked so that user could land a PR for their project. The primary author of memmap has recent nontrivial GH activity. Will poke around forums.

@ranweiler
Copy link
Member

I left a comment in the repo, volunteering to help maintain, and pinging the latest active co-maintainer, who at least has repo activity in 2020.

@ranweiler
Copy link
Member

No response from the memmap maintainer; based on discussion, I think we should switch to memmap2-rs.

@ranweiler ranweiler mentioned this issue Jan 11, 2021
Merged
@ghost ghost closed this as completed in #428 Jan 12, 2021
ghost pushed a commit that referenced this issue Jan 12, 2021
@ranweiler
Switch to memmap2 (#428)
70d41d1 
- Depend on `memmap2`, a maintained fork of the abandoned `memmap` crate
- Revert #364, which temporarily suppressed the relevant `cargo-audit` CI error

Closes #363.
@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ranweiler ranweiler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to memmap2 ranweiler/onefuzz
3 participants
@ranweiler @lzybkr @bmc-msft