Skip to content

Commit 7040a41

Browse files
committed
fix webdriver tests
1 parent a37a7e7 commit 7040a41

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

extension/background.js

+4-5
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class Extension {
5353
const debuggee = { tabId }
5454
await chrome.debugger.attach(debuggee, '1.3')
5555
if (chrome.runtime.lastError) {
56-
console.error('Failed to attach debugger:', chrome.runtime.lastError.message);
56+
debugLog('Failed to attach debugger:', chrome.runtime.lastError.message);
5757
return;
5858
}
5959
debugLog('Debugger attached to tab:', debuggee.tabId);
@@ -65,7 +65,7 @@ class Extension {
6565
if (socket.readyState === WebSocket.OPEN) {
6666
socket.send(JSON.stringify(data));
6767
} else {
68-
console.error('WebSocket is not open. Cannot send data.');
68+
debugLog('WebSocket is not open. Cannot send data.');
6969
}
7070
}
7171
adapter.onClose = async () => {
@@ -79,7 +79,7 @@ class Extension {
7979
});
8080
socket.addEventListener('message', (e) => adapter.onBrowserMessage(targetId, browserContextId, e));
8181
socket.addEventListener('error', (event) => {
82-
console.error('WebSocket error:', event);
82+
debugLog('WebSocket error:', event);
8383
adapter.detach();
8484
});
8585
socket.addEventListener('close', async () => {
@@ -108,7 +108,6 @@ class CDPAdapter {
108108
* @returns
109109
*/
110110
async onBrowserMessage(targetId, browserContextId, event) {
111-
console.error('Received message from browser:', event);
112111
try {
113112
const message = JSON.parse(await event.data.text());
114113
if (message.method === 'Browser.getVersion') {
@@ -159,7 +158,7 @@ class CDPAdapter {
159158
});
160159
}
161160
} catch (e) {
162-
console.error('Error processing WebSocket message:', e);
161+
debugLog('Error processing WebSocket message:', e);
163162
}
164163
}
165164

tests/fixtures.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -169,15 +169,18 @@ export const test = baseTest.extend<TestFixtures & TestOptions, WorkerFixtures>(
169169
mcpExtensionPage: async ({ mcpExtension, mcpHeadless }, use) => {
170170
if (!mcpExtension)
171171
return await use(undefined);
172+
const webSocketPort = 8900 + test.info().parallelIndex * 4;
172173
const pathToExtension = path.join(url.fileURLToPath(import.meta.url), '../../extension');
173174
const context = await chromium.launchPersistentContext('', {
174175
headless: mcpHeadless,
175176
args: [
176177
`--disable-extensions-except=${pathToExtension}`,
177178
`--load-extension=${pathToExtension}`,
178-
'--enable-features=AllowContentInitiatedDataUrlNavigations'
179+
'--enable-features=AllowContentInitiatedDataUrlNavigations',
180+
`--remote-debugging-port=1234`,
179181
],
180182
channel: 'chromium',
183+
...{ assistantMode: true, webSocketPort },
181184
});
182185
const page = context.pages()[0];
183186
// Do not auto dismiss dialogs.

tests/webdriver.spec.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616

1717
import { test, expect } from './fixtures.js';
1818

19-
test('do not falsely advertise user agent as a test driver', async ({ client, server, mcpBrowser, mcpExtension }) => {
20-
test.fixme(!!mcpExtension, 'To be investigated why this is failing');
19+
test('do not falsely advertise user agent as a test driver', async ({ client, server, mcpBrowser }) => {
2120
test.skip(mcpBrowser === 'firefox');
2221
test.skip(mcpBrowser === 'webkit');
2322
server.route('/', (req, res) => {

0 commit comments

Comments
 (0)