Skip to content

fix: ensure browser_snapshot correctly handles undefined arguments #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

LymanBE
Copy link

@LymanBE LymanBE commented May 9, 2025

This commit resolves an issue where mcp7_browser_snapshot would fail
with an "invalid_type" error if called with no arguments. The root cause
was 'undefined' being passed to Zod's parse method for a schema
expecting an object. The fix ensures an empty object {} is provided
if parameters are undefined.

Additionally, the npm build script in package.json has been updated
from 'tsc' to 'npx tsc' to improve build reliability, particularly in
environments where TypeScript might not be globally installed or in the PATH.

This commit resolves an issue where mcp7_browser_snapshot would fail with an "invalid_type" error if called with no arguments. The root cause was 'undefined' being passed to Zod's parse method for a schema expecting an object. The fix ensures an empty object {} is provided if parameters are undefined.

Additionally, the npm build script in package.json has been updated from 'tsc' to 'npx tsc' to improve build reliability, particularly in environments where TypeScript might not be globally installed or in the PATH.
@LymanBE
Copy link
Author

LymanBE commented May 9, 2025

@microsoft-github-policy-service agree

@@ -16,7 +16,7 @@
},
"license": "Apache-2.0",
"scripts": {
"build": "tsc",
"build": "npx tsc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"build": "npx tsc",
"build": "tsc",

I don't think thats right, if you run npm install it will put tsc into the node_modules directory and add it to PATH as soon as you run a package.json script.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're Probably right.

The main issue I found was the inability to handle empty args for the snapshot.

That seemed to break this MCP server for both Cursor and Windsurf at least in each environment I tested.

This seems like a large proportion of potential users for this, so rather than just complain with an issue report, I figured I'd share the fix I implemented and have found to work.

The other change wasn't necessary and I shouldn't have included it, so that's on me.

Let me know if you'd like me to adjust do anything to address this.

This MCP server is fantastic, btw.

@pavelfeldman
Copy link
Member

Thank you for your PR, I updated our tests to account for empty arguments and fixed the issue, v0.0.24 should have it addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants