Skip to content

[rush] does not install/link all dependencies (using npm) #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
trusktr opened this issue Jan 21, 2020 · 3 comments
Open
1 of 2 tasks

[rush] does not install/link all dependencies (using npm) #1703

trusktr opened this issue Jan 21, 2020 · 3 comments

Comments

@trusktr
Copy link

trusktr commented Jan 21, 2020

Is this a feature or a bug?

  • Feature
  • Bug

NOTE, I'm using npmVersion in rush.json. I wanted to try pnpm, but that has a bug.

Please describe the actual behavior.

Sometimes If I run rush add --package some-package --caret && rush update inside a package in the rush-managed repo, then look inside the respective package's node_modules folder, there is no some-package link there. It doesn't get linked.

What is the expected behavior?

It should just work.

workaround

To get things to work consistently, this is the full thing that I currently do:

rush add --package some-package --caret && \
  rush purge && rm -rf common/scripts common/temp && \
  rm -f common/config/rush/npm-shrinkwrap.json && \
  find . -name node_modules | xargs rm -rf && find . -name .rush | xargs rm -rf && \
  rush update

Note, the part rm -f common/config/rush/npm-shrinkwrap.json is there because otherwise issue #1706 happens (not every time, but sometimes).

If this is a bug, please provide the tool version, Node.js version, and OS.

  • Tool: rush
  • Tool Version: 5.18.0
@trusktr trusktr changed the title [rush] is not linking all dependencies [rush] not able to install dependencies Jan 21, 2020
@trusktr trusktr closed this as completed Jan 21, 2020
@trusktr
Copy link
Author

trusktr commented Jan 23, 2020

Rush is not installing/linking all dependencies (using npm). I cleaned up the issue, and am able to describe exactly the behavior I am encountering.

@trusktr trusktr changed the title [rush] not able to install dependencies [rush] does not install/link all dependencies (using npm) Jan 23, 2020
@trusktr trusktr reopened this Jan 25, 2020
@trusktr
Copy link
Author

trusktr commented Jan 25, 2020

Just noting that I re-opened this issue after updating the description. I don't have a specific reproduction yet.

@trusktr
Copy link
Author

trusktr commented Feb 16, 2020

May this issue be due to the not-yet-supported use of NPM 6?

@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant