[rush] does not install/link all dependencies (using npm)

[trusktr]

Is this a feature or a bug?

• Feature
• Bug

NOTE, I'm using npmVersion in rush.json. I wanted to try pnpm, but that has a bug.

Please describe the actual behavior.

Sometimes If I run rush add --package some-package --caret && rush update inside a package in the rush-managed repo, then look inside the respective package's node_modules folder, there is no some-package link there. It doesn't get linked.

What is the expected behavior?

It should just work.

workaround

To get things to work consistently, this is the full thing that I currently do:

rush add --package some-package --caret && \
  rush purge && rm -rf common/scripts common/temp && \
  rm -f common/config/rush/npm-shrinkwrap.json && \
  find . -name node_modules | xargs rm -rf && find . -name .rush | xargs rm -rf && \
  rush update

Note, the part rm -f common/config/rush/npm-shrinkwrap.json is there because otherwise issue #1706 happens (not every time, but sometimes).

If this is a bug, please provide the tool version, Node.js version, and OS.

• Tool: rush
• Tool Version: 5.18.0

[trusktr]

Rush is not installing/linking all dependencies (using npm). I cleaned up the issue, and am able to describe exactly the behavior I am encountering.

[trusktr]

Just noting that I re-opened this issue after updating the description. I don't have a specific reproduction yet.

[trusktr]

May this issue be due to the not-yet-supported use of NPM 6?