Skip to content

Don't wrap every exception thrown by the connector with VectorStoreOperationException #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adamsitnik opened this issue Apr 11, 2025 · 1 comment
Open

Don't wrap every exception thrown by the connector with VectorStoreOperationException #11512

adamsitnik opened this issue Apr 11, 2025 · 1 comment
Assignees
@westey-m
Labels
Build Features planned for next Build conference msft.ext.vectordata Related to Microsoft.Extensions.VectorData

Comments

@adamsitnik
Copy link
Member

We need to be catching specific exceptions and make sure we don't wrap with VectorStoreOperationException any of the following:

  • ArgumentException
  • NotSupportedException
  • TaskCanceledException

cc @roji @westey-m
@adamsitnik adamsitnik added Build Features planned for next Build conference msft.ext.vectordata Related to Microsoft.Extensions.VectorData labels Apr 11, 2025
@roji roji mentioned this issue Apr 11, 2025
Merged
@markwallace-microsoft markwallace-microsoft moved this to Backlog: Planned in Semantic Kernel Apr 14, 2025
@roji
Copy link
Member

roji commented Apr 15, 2025

While doing this, also ensure that we're indeed wrapping the relevant connector-specific exceptions everywhere, as discussed in #10883.

@roji roji mentioned this issue Apr 15, 2025
Closed
@westey-m westey-m moved this from Backlog: Planned to Sprint: Planned in Semantic Kernel Apr 15, 2025
@westey-m westey-m moved this from Sprint: Planned to Sprint: In Review in Semantic Kernel Apr 23, 2025
@westey-m westey-m moved this from Sprint: In Review to Sprint: Planned in Semantic Kernel Apr 23, 2025
@westey-m westey-m moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernel Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westey-m westey-m

Labels
Build Features planned for next Build conference msft.ext.vectordata Related to Microsoft.Extensions.VectorData
Projects
Semantic Kernel
Status: Sprint: In Progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@roji @adamsitnik @markwallace-microsoft @westey-m