Skip to content

Compile errors on TextDocumentSaveReason and MessageType. #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aeschli opened this issue Jan 18, 2017 · 2 comments
Closed

Compile errors on TextDocumentSaveReason and MessageType. #145

aeschli opened this issue Jan 18, 2017 · 2 comments
Assignees

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 18, 2017

After migrating to ^3.0.2-beta.5 I get the following compile errors in vscode. Any idea?

[19:33:49] Error: /home/aeschli/workspaces/vscode/extensions/html/server/src/modes/javascriptMode.ts(67,11): Type '{ range: Range; severity: number; message: string; }[]' is not assignable to type 'Diagnostic[]'.
Type '{ range: Range; severity: number; message: string; }' is not assignable to type 'Diagnostic'.
Types of property 'severity' are incompatible.
Type 'number' is not assignable to type 'MessageType'.
[19:33:49] Error: /home/aeschli/workspaces/vscode/extensions/html/server/src/modes/javascriptMode.ts(165,12): Type '{ range: Range; kind: number; }[]' is not assignable to type 'DocumentHighlight[]'.
Type '{ range: Range; kind: number; }' is not assignable to type 'DocumentHighlight'.
Types of property 'kind' are incompatible.
Type 'number' is not assignable to type 'TextDocumentSaveReason'.

@aeschli aeschli assigned aeschli and dbaeumer and unassigned aeschli Jan 18, 2017
@dbaeumer
Copy link
Member

See microsoft/TypeScript#13594

I will more clearly type the enum constants since it helps work around this.

@dbaeumer
Copy link
Member

I will close the issue since there is nothing I can do right now. See the TS issue for details.

@aeschli fixed on the VS Code side by typing the fat arrow.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants