Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: WinGet incorrectly identifies the Lazer version of ppy.osu as the Stable version. #246108

Open
2 tasks done
DuckDuckStudio opened this issue Apr 7, 2025 · 5 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage This work item needs to be triaged by a member of the core team.

Comments

@DuckDuckStudio
Copy link
Contributor

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Image

Steps to reproduce

winget install --id ppy.osu --version 2025.321.0 --source winget -e
winget update

If it doesn't reproduce, try installing both the Lazer version and the Stable version?

Actual behavior

Unable to test due to #246106

Expected behavior

No updates available/updates denied.

Environment

Windows 程序包管理器 v1.10.340
版权所有 (C) Microsoft Corporation。保留所有权利。

Windows: Windows.Desktop v10.0.22631.5039
系统体系结构: X64
软件包: Microsoft.DesktopAppInstaller v1.25.340.0

Winget 目录
-------------------------------------------------------------------------------------------------------------------
日志                   %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
用户设置               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
可移植链接目录(用户)   %LOCALAPPDATA%\Microsoft\WinGet\Links
可移植链接目录(计算机) C:\Program Files\WinGet\Links
可移植包根目录(用户)   %LOCALAPPDATA%\Microsoft\WinGet\Packages
可移植包根目录         C:\Program Files\WinGet\Packages
可移植包根目录 (x86)   C:\Program Files (x86)\WinGet\Packages
安装程序下载           %USERPROFILE%\Downloads
配置模块               %LOCALAPPDATA%\Microsoft\WinGet\Configuration\Modules

链接
----------------------------------------------------------------------------
隐私声明             https://aka.ms/winget-privacy
许可协议             https://aka.ms/winget-license
第三方声明           https://aka.ms/winget-3rdPartyNotice
主页                 https://aka.ms/winget
Windows 应用商店条款 https://www.microsoft.com/en-us/storedocs/terms-of-sale

管理员设置                                状态
------------------------------------------------
LocalManifestFiles                        已启用
BypassCertificatePinningForMicrosoftStore 已禁用
InstallerHashOverride                     已禁用
LocalArchiveMalwareScanOverride           已禁用
ProxyCommandLineOptions                   已禁用
DefaultProxy                              已禁用

Screenshots and Logs

No response

@DuckDuckStudio DuckDuckStudio added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Apr 7, 2025
@Dragon1573
Copy link
Contributor

Steps to reproduce

......

⚠ Unable to reproduce the issue

Image

If it doesn't reproduce, try installing both the Lazer version and the Stable version?

It's still "un-produce-able".

Image

@DuckDuckStudio
Copy link
Contributor Author

DuckDuckStudio commented Apr 7, 2025

If it doesn't reproduce, try installing both the Lazer version and the Stable version?

It's still "un-produce-able".

Image

Image
You have successfully reproduced the similar issue at this point :)
Uninstall the Stable version of osu (I did it manually through settings) should give you the same results.

@Dragon1573
Copy link
Contributor

✅ Issue proved.

Image
Image
Image
Image

@Dragon1573
Copy link
Contributor

@DuckDuckStudio Can't sure if following patches can resolve the issue. Could you please try it?

Exported by git diff --patch

diff --git a/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.en-US.yaml b/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.en-US.yaml
index 5ae312afc5e..9dfdec7a04c 100644
--- a/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.en-US.yaml
+++ b/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.en-US.yaml
@@ -9,7 +9,7 @@ PublisherUrl: https://ppy.sh/
 PublisherSupportUrl: https://github.com/ppy/osu/issues
 PrivacyUrl: https://osu.ppy.sh/legal/en/Privacy
 Author: ppy Pty Ltd
-PackageName: osu!
+PackageName: osu!(lazer)
 PackageUrl: https://osu.ppy.sh/
 License: MIT
 LicenseUrl: https://github.com/ppy/osu/raw/master/LICENCE
diff --git a/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.ja-JP.yaml b/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.ja-JP.yaml
index 4da1828f616..8f92516f0ed 100644
--- a/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.ja-JP.yaml
+++ b/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.ja-JP.yaml
@@ -9,7 +9,7 @@ PublisherUrl: https://ppy.sh/
 PublisherSupportUrl: https://github.com/ppy/osu/issues
 PrivacyUrl: https://osu.ppy.sh/legal/en/Privacy
 Author: ppy Pty Ltd
-PackageName: osu!
+PackageName: osu!(lazer)
 PackageUrl: https://osu.ppy.sh/
 License: MIT
 LicenseUrl: https://github.com/ppy/osu/raw/master/LICENCE
diff --git a/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.zh-CN.yaml b/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.zh-CN.yaml
index 7d60d164b9e..a7a6a80a694 100644
--- a/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.zh-CN.yaml
+++ b/manifests/p/ppy/osu/2025.321.0/ppy.osu.locale.zh-CN.yaml
@@ -9,7 +9,7 @@ PublisherUrl: https://ppy.sh/
 PublisherSupportUrl: https://github.com/ppy/osu/issues
 PrivacyUrl: https://osu.ppy.sh/legal/zh/Privacy
 Author: ppy Pty Ltd
-PackageName: osu!
+PackageName: osu!(lazer)
 PackageUrl: https://osu.ppy.sh/
 License: MIT
 LicenseUrl: https://github.com/ppy/osu/raw/master/LICENCE
diff --git a/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.en-US.yaml b/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.en-US.yaml
index 610e061c0d9..fa310f82966 100644
--- a/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.en-US.yaml
+++ b/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.en-US.yaml
@@ -7,7 +7,7 @@ PackageLocale: en-US
 Publisher: ppy
 PublisherUrl: https://ppy.sh/
 Author: ppy Pty Ltd
-PackageName: osu! (Stable)
+PackageName: osu!
 PackageUrl: https://osu.ppy.sh/
 License: Freeware
 Copyright: Copyright (c) 2025 ppy Pty Ltd
diff --git a/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.zh-CN.yaml b/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.zh-CN.yaml
index dc47c4f7a2f..96dca64ebca 100644
--- a/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.zh-CN.yaml
+++ b/manifests/p/ppy/osu/stable/20250401.2/ppy.osu.stable.locale.zh-CN.yaml
@@ -7,7 +7,7 @@ PackageLocale: zh-CN
 Publisher: ppy
 PublisherUrl: https://ppy.sh/
 Author: ppy Pty Ltd
-PackageName: osu! (Stable)
+PackageName: osu!
 PackageUrl: https://osu.ppy.sh/
 License: 免费软件
 Copyright: Copyright (c) 2025 ppy Pty Ltd

@DuckDuckStudio
Copy link
Contributor Author

DuckDuckStudio commented Apr 9, 2025

@DuckDuckStudio Can't sure if following patches can resolve the issue. Could you please try it?

I'm not sure. After installing them using the locally modified manifest, WinGet doesn't see them as either Lazer or Stable versions, and naturally there are no available updates. :(

Image

Edit:
Changing the PackageName of the Lazer version and adding AppsAndFeaturesEntries to them does not solve the problem :(

> winget update
名称                                           ID                                    版本          可用          源
-----------------------------------------------------------------------------------------------------------------------
osu!(lazer)                                    ppy.osu.stable                        < 20250401.2  20250401.2    winget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage This work item needs to be triaged by a member of the core team.
Projects
None yet
Development

No branches or pull requests

2 participants