fix text response

Author: minhlucvanncc

Diff for: nodes/Browserless/v2/helpers/hooks.ts

@@ -56,33 +56,23 @@ function getresponseContentType (response: IN8nHttpFullResponse): string {
 }
 
 function getFileTypeFromContentType (contentType: string): string {
+  // application/pdf -> pdf
+  // image/jpeg -> jpeg
   const type = contentType.split(';')[0].trim()
+
+  // any/thing -> any
+  if (type.includes('/')) {
+    return type.split('/')[0]
+  }
+
   return type
 }
 
 function getFileExtensionFromContentType (contentType: string): string {
   const type = contentType.split(';')[0].trim()
 
-  // @ts-ignore
-  console.log('type', contentType, type, type.split('/')[1])
-
-  if (/^image\//.test(type)) {
-    return type.split('/')[1]
-  }
-
-  if (/^audio\//.test(type)) {
-    return type.split('/')[1]
-  }
-
-  if (/^video\//.test(type)) {
-    return type.split('/')[1]
-  }
-
-  if (/^text\//.test(type)) {
-    return type.split('/')[1]
-  }
-
-  if (/^application\//.test(type)) {
+  // any/thing -> thing
+  if (typeof type === 'string' && type.includes('/')) {
     return type.split('/')[1]
   }
 
@@ -99,14 +89,11 @@ export const postReceiveActionBinaryData: PostReceiveAction =
 
     const { binary } = items[0]
 
-    if (binary && binary.data) {
+    if (binary && binary.data && binary.data.mimeType === 'text/plain') {
       const data = binary.data as IBinaryData
       data.mimeType = contentType
       data.fileType = getFileTypeFromContentType(contentType) as BinaryFileType
       data.fileExtension = getFileExtensionFromContentType(contentType)
-
-      // @ts-ignore
-      console.log('data', data)
     }
 
     return items

Diff for: nodes/Browserless/v2/properties.json

@@ -51,12 +51,11 @@
           "output": {
             "postReceive": [
               {
-                "type": "binaryData",
+                "type": "setKeyValue",
                 "properties": {
-                  "destinationProperty": "data"
+                  "data": "={{$response.body}}"
                 }
-              },
-              "${helpers.hooks.postReceiveActionBinaryData}"
+              }
             ]
           }
         }
@@ -74,12 +73,11 @@
           "output": {
             "postReceive": [
               {
-                "type": "binaryData",
+                "type": "setKeyValue",
                 "properties": {
-                  "destinationProperty": "data"
+                  "data": "={{$response.body}}"
                 }
-              },
-              "${helpers.hooks.postReceiveActionBinaryData}"
+              }
             ]
           }
         }
@@ -93,6 +91,16 @@
           "request": {
             "method": "POST",
             "url": "=/content"
+          },
+          "output": {
+            "postReceive": [
+              {
+                "type": "setKeyValue",
+                "properties": {
+                  "data": "={{$response.body}}"
+                }
+              }
+            ]
           }
         }
       },
@@ -105,6 +113,16 @@
           "request": {
             "method": "POST",
             "url": "=/download"
+          },
+          "output": {
+            "postReceive": [
+              {
+                "type": "setKeyValue",
+                "properties": {
+                  "data": "={{$response.body}}"
+                }
+              }
+            ]
           }
         }
       },
@@ -117,6 +135,16 @@
           "request": {
             "method": "POST",
             "url": "=/function"
+          },
+          "output": {
+            "postReceive": [
+              {
+                "type": "setKeyValue",
+                "properties": {
+                  "data": "={{$response.body}}"
+                }
+              }
+            ]
           }
         }
       },

Diff for: nodes/Browserless/v2/resources/browser-rest-apis/content/index.ts

@@ -25,6 +25,16 @@ const rawOption: INodePropertyOptions = {
       method: 'POST',
       url: '=/content',
     },
+    output: {
+      postReceive: [
+        {
+          type: 'setKeyValue',
+          properties: {
+            data: '={{$response.body}}',
+          },
+        },
+      ],
+    },
   },
 }
 

Diff for: nodes/Browserless/v2/resources/browser-rest-apis/download/index.ts

@@ -25,6 +25,16 @@ const rawOption: INodePropertyOptions = {
       method: 'POST',
       url: '=/download',
     },
+    output: {
+      postReceive: [
+        {
+          type: 'setKeyValue',
+          properties: {
+            data: '={{$response.body}}',
+          },
+        },
+      ],
+    },
   },
 }
 

Diff for: nodes/Browserless/v2/resources/browser-rest-apis/execute-function/index.ts

@@ -25,6 +25,16 @@ const rawOption: INodePropertyOptions = {
       method: 'POST',
       url: '=/function',
     },
+    output: {
+      postReceive: [
+        {
+          type: 'setKeyValue',
+          properties: {
+            data: '={{$response.body}}',
+          },
+        },
+      ],
+    },
   },
 }
 

Diff for: nodes/Browserless/v2/resources/browser-rest-apis/pdf/index.ts

@@ -28,12 +28,11 @@ const rawOption: INodePropertyOptions = {
     output: {
       postReceive: [
         {
-          type: 'binaryData',
+          type: 'setKeyValue',
           properties: {
-            destinationProperty: 'data',
+            data: '={{$response.body}}',
           },
         },
-        helpers.hooks.postReceiveActionBinaryData,
       ],
     },
   },

Diff for: nodes/Browserless/v2/resources/browser-rest-apis/screenshot/index.ts

@@ -28,12 +28,11 @@ const rawOption: INodePropertyOptions = {
     output: {
       postReceive: [
         {
-          type: 'binaryData',
+          type: 'setKeyValue',
           properties: {
-            destinationProperty: 'data',
+            data: '={{$response.body}}',
           },
         },
-        helpers.hooks.postReceiveActionBinaryData,
       ],
     },
   },