Skip to content

Commit 1232fe3

Browse files
robinbraemernicksrandall
authored andcommitted
Fix typos (graph-gophers#48)
* Update dataloader.go * Update inMemoryCache.go * Update key.go * Update README.md * Update inMemoryCache_go19.go
1 parent 65f631c commit 1232fe3

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ You're welcome to install the v1 version of this library.
4242
## Cache
4343
This implementation contains a very basic cache that is intended only to be used for short lived DataLoaders (i.e. DataLoaders that ony exsist for the life of an http request). You may use your own implementation if you want.
4444

45-
> it also has a `NoCache` type that implements the cache interface but all methods are noop. If you do not wish to cache anyting.
45+
> it also has a `NoCache` type that implements the cache interface but all methods are noop. If you do not wish to cache anything.
4646
4747
## Examples
4848
There are a few basic examples in the example folder.

dataloader.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type Interface interface {
2727
Prime(ctx context.Context, key Key, value interface{}) Interface
2828
}
2929

30-
// BatchFunc is a function, which when given a slice of keys (string), returns an slice of `results`.
30+
// BatchFunc is a function, which when given a slice of keys (string), returns a slice of `results`.
3131
// It's important that the length of the input keys matches the length of the output results.
3232
//
3333
// The keys passed to this function are guaranteed to be unique

inMemoryCache.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import (
88
)
99

1010
// InMemoryCache is an in memory implementation of Cache interface.
11-
// this simple implementation is well suited for
11+
// This simple implementation is well suited for
1212
// a "per-request" dataloader (i.e. one that only lives
13-
// for the life of an http request) but it not well suited
13+
// for the life of an http request) but it's not well suited
1414
// for long lived cached items.
1515
type InMemoryCache struct {
1616
items map[string]Thunk

inMemoryCache_go19.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import (
88
)
99

1010
// InMemoryCache is an in memory implementation of Cache interface.
11-
// this simple implementation is well suited for
11+
// This simple implementation is well suited for
1212
// a "per-request" dataloader (i.e. one that only lives
13-
// for the life of an http request) but it not well suited
13+
// for the life of an http request) but it's not well suited
1414
// for long lived cached items.
1515
type InMemoryCache struct {
1616
items *sync.Map

key.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type StringKey string
2626
// String is an identity method. Used to implement String interface
2727
func (k StringKey) String() string { return string(k) }
2828

29-
// String is an identity method. Used to implement Key Raw
29+
// Raw is an identity method. Used to implement Key Raw
3030
func (k StringKey) Raw() interface{} { return k }
3131

3232
// NewKeysFromStrings converts a `[]strings` to a `Keys` ([]Key)

0 commit comments

Comments
 (0)