Skip to content

feat(ui): add spinner to image uploader #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(ui): add spinner to image uploader #3350

wants to merge 1 commit into from

Conversation

Erb3
Copy link
Contributor

@Erb3 Erb3 commented Mar 6, 2025 •
edited
Loading

  • Added a rotating spinner while uploading the file to not confuse users (uploading can take several seconds)
  • fmt

@Erb3
feat(ui): add spinner to image uploader
f1c5162 
- Added a rotating spinner while uploading the file to not confuse users
- Automatic webstorm formatting
- Simplify assign-and-return (`uploadImagesFromList`)
@Erb3
Copy link
Contributor Author

Erb3 commented Mar 7, 2025

It works, but I'm not 100% happy. The FileUpload is being used in many places, and I think it would make more sense to take an async callback to know once the upload finished. That way we can add the spinner in the component.

@Erb3 Erb3 marked this pull request as draft March 7, 2025 06:46
@Erb3
Copy link
Contributor Author

Erb3 commented Mar 7, 2025

Superseded by #3355

@Erb3 Erb3 closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Erb3