Ensure valid C# for default args assigned secondary bases

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/Generator/Generators/CSharp/CSharpExpressionPrinter.cs

@@ -31,19 +31,8 @@ public string VisitParameter(Parameter parameter)
                 return $"({desugared.Visit(typePrinter)}) {expression}";
             var finalType = (desugared.GetFinalPointee() ?? desugared).Desugar();
             if (finalType.TryGetClass(out var @class) && @class.IsInterface)
-            {
-                string cast;
-                if (parameter.DefaultArgument.Declaration is Method method &&
-                    method.IsConstructor && method.Namespace == @class.OriginalClass)
-                {
-                    cast = string.Empty;
-                }
-                else
-                {
-                    cast = $"({@class.OriginalClass.Visit(typePrinter)}) ";
-                }
-                return cast + expression;
-            }
+                return $@"({@class.Visit(typePrinter)}) ({
+                    @class.OriginalClass.Visit(typePrinter)}) {expression}";
             return expression;
         }
 

tests/CSharp/CSharp.Tests.cs

@@ -342,6 +342,7 @@ public void TestDefaultArguments()
             methodsWithDefaultValues.DefaultWithFreeConstantInNameSpace();
             methodsWithDefaultValues.DefaultWithStdNumericLimits(10, 5);
             methodsWithDefaultValues.DefaultWithSpecialization();
+            methodsWithDefaultValues.DefaultOverloadedImplicitCtor();
             methodsWithDefaultValues.DefaultWithParamNamedSameAsMethod(5);
         }
     }

tests/CSharp/CSharp.cpp

@@ -822,6 +822,14 @@ void MethodsWithDefaultValues::defaultWithSpecialization(IndependentFields<int>
 {
 }
 
+void MethodsWithDefaultValues::defaultOverloadedImplicitCtor(P p)
+{
+}
+
+void MethodsWithDefaultValues::defaultOverloadedImplicitCtor(Qux q)
+{
+}
+
 int MethodsWithDefaultValues::DefaultWithParamNamedSameAsMethod(int DefaultWithParamNamedSameAsMethod, const Foo& defaultArg)
 {
     return 1;

tests/CSharp/CSharp.h

@@ -483,6 +483,8 @@ class DLL_API MethodsWithDefaultValues : public Quux
     void defaultWithStdNumericLimits(double d = 1.0, int i = std::numeric_limits<double>::infinity());
     void defaultWithParamRequiringRename(_ClassWithLeadingUnderscore* ptr = nullptr);
     void defaultWithSpecialization(IndependentFields<int> specialization = IndependentFields<int>());
+    void defaultOverloadedImplicitCtor(P p);
+    void defaultOverloadedImplicitCtor(Qux q = Qux());
     int DefaultWithParamNamedSameAsMethod(int DefaultWithParamNamedSameAsMethod, const Foo& defaultArg = Foo());
     int getA();
 private: