Skip to content

Commit 51519a0

Browse files
committed
Expanded criteria for what constitutes an attached property.
Related to #426
1 parent 02321c0 commit 51519a0

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

mdoc/Mono.Documentation/Util/AttachedEntitiesHelper.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,21 +144,21 @@ private static bool IsAttachedProperty(FieldDefinition field, Dictionary<string,
144144

145145
private static bool IsAttachedPropertyGetMethod(MethodDefinition method)
146146
{
147-
return method.Parameters.Count == 1
148-
149-
// returns a value of type dp.PropertyType (or IsAssignableTo…), where dp is the value of the static field.
150-
// && IsAssignableTo(method.ReturnType, "");
151-
152-
// The Get method takes one argument of type DependencyObject(or something IsAssignableTo(DependencyObject),
153-
&& (IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullName) || IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullNameXaml));
147+
return method.Parameters.Count == 1
148+
149+
// returns a value of type dp.PropertyType (or IsAssignableTo…), where dp is the value of the static field.
150+
// && IsAssignableTo(method.ReturnType, "");
151+
152+
// The Get method takes one argument of type DependencyObject(or something IsAssignableTo(DependencyObject),
153+
;//&& (IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullName) || IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullNameXaml));
154154
}
155155

156156
private static bool IsAttachedPropertySetMethod(MethodDefinition method)
157157
{
158158
return method.Parameters.Count == 2// The Set method takes two arguments.
159159

160160
// The first has type DependencyObject(or IsAssignableTo…),
161-
&& (IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullName) || IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullNameXaml))
161+
//s&& (IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullName) || IsAssignableTo(method.Parameters[0].ParameterType, Consts.DependencyObjectFullNameXaml))
162162

163163
// the second has type dp.PropertyType (or IsAssignableTo…).
164164
// && IsAssignableTo(method.Parameters[1].ParameterType, "")

0 commit comments

Comments
 (0)