Don't use task if not necessary in GetPropertiesForTypeAsync

netonjm · netonjm · commit 2b19864b2c30 · 2019-10-08T11:18:23.000+02:00
diff --git a/main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/NativePropertyEditor/ComponentModelEditorProvider.cs b/main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/NativePropertyEditor/ComponentModelEditorProvider.cs
@@ -76,10 +76,9 @@ public Task<object> CreateObjectAsync (ITypeInfo type)
 
 		public Task<IReadOnlyCollection<IPropertyInfo>> GetPropertiesForTypeAsync (ITypeInfo type)
 		{
-			return Task.Run (() => {
-				var prov = target?.Providers ?? Array.Empty<object> ();
-				return (IReadOnlyCollection<IPropertyInfo>)GetPropertiesForProviders (prov);
-			});
+			var prov = target?.Providers ?? Array.Empty<object> ();
+			var providers = (IReadOnlyCollection<IPropertyInfo>)GetPropertiesForProviders (prov);
+			return Task.FromResult (providers);
 		}
 
 		public static IReadOnlyList<DescriptorPropertyInfo> GetPropertiesForProviders (object[] providers)

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,9 @@ public Task<object> CreateObjectAsync (ITypeInfo type)`
`76`	`76`
`77`	`77`	`public Task<IReadOnlyCollection<IPropertyInfo>> GetPropertiesForTypeAsync (ITypeInfo type)`
`78`	`78`	`{`
`79`		`- return Task.Run (() => {`
`80`		`- var prov = target?.Providers ?? Array.Empty<object> ();`
`81`		`- return (IReadOnlyCollection<IPropertyInfo>)GetPropertiesForProviders (prov);`
`82`		`- });`
	`79`	`+ var prov = target?.Providers ?? Array.Empty<object> ();`
	`80`	`+ var providers = (IReadOnlyCollection<IPropertyInfo>)GetPropertiesForProviders (prov);`
	`81`	`+ return Task.FromResult (providers);`
`83`	`82`	`}`
`84`	`83`
`85`	`84`	`public static IReadOnlyList<DescriptorPropertyInfo> GetPropertiesForProviders (object[] providers)`