Skip to content

Commit 4a36c6f

Browse files
committed
address review
1 parent ca8677d commit 4a36c6f

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.circleci/config.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
command: |
3535
python3.8 -m venv venv/
3636
venv/bin/pip install pip-tools --constraint requirements.in
37-
venv/bin/pip-sync
37+
venv/bin/pip-sync --pip-args=--no-deps
3838
- run:
3939
name: Yamllint Test
4040
command: PATH="venv/bin:$PATH" yamllint -c .yamllint.yaml .
@@ -176,7 +176,8 @@ jobs:
176176
apt update
177177
apt install -y maven default-jdk-headless
178178
mvn dependency:copy-dependencies
179-
venv/bin/pip-sync requirements.txt java-requirements.txt
179+
venv/bin/pip-sync --pip-args=--no-deps requirements.txt \
180+
java-requirements.txt
180181
- run:
181182
name: PyTest Integration Test
182183
# Google's client libraries will check for
@@ -497,8 +498,8 @@ jobs:
497498
bigquery-etl-main
498499
499500
cd bigquery-etl-main
500-
pip install -r requirements.txt
501-
pip install -r java-requirements.txt
501+
pip install --no-deps -r requirements.txt
502+
pip install --no-deps -r java-requirements.txt
502503
mvn dependency:copy-dependencies
503504
./script/bqetl generate all \
504505
--target-project moz-fx-data-shared-prod

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ venv/bin/pre-commit install
4949
4. Download java dependencies
5050
```bash
5151
mvn dependency:copy-dependencies
52-
venv/bin/pip-sync requirements.txt java-requirements.txt
52+
venv/bin/pip-sync --pip-args=--no-deps requirements.txt java-requirements.txt
5353
```
5454

5555
Finally, if you are using Visual Studio Code, you may also wish to use our recommended defaults:

0 commit comments

Comments
 (0)