Skip to content

Crashes when built using -Cpanic=abort #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
h33p opened this issue Sep 1, 2020 · 1 comment
Open

Crashes when built using -Cpanic=abort #569

h33p opened this issue Sep 1, 2020 · 1 comment

Comments

@h33p
Copy link

h33p commented Sep 1, 2020

proc-macro2 crashes during parsing when building with -Cpanic=abort flag. cbindgen-0.14.4/src/bindgen/parser.rs:229 leads all the way to proc-macro2-1.0.19/src/detection.rs:59 where it panics and aborts. This is a proc-macro2 issue in question: dtolnay/proc-macro2#218

Solution would be to incorporate proc_macro2::fallback::force() somewhere in the code.
elbe0046 added a commit to elbe0046/cbindgen that referenced this issue Jun 20, 2021
@elbe0046
parser: force proc macro fallback
1ecc6bb 
Incorate dtolnay/proc-macro2#220 to fix the
case where a binary which is built with `panic = "abort"` aborts when
calling into cbdingen functionality.

mozilla#569

Signed-off-by: Grant Elbert <[email protected]>
elbe0046 added a commit to elbe0046/cbindgen that referenced this issue Jun 20, 2021
@elbe0046
parser: force proc macro fallback
31a365d 
Incorporate dtolnay/proc-macro2#220 to fix
the case where a binary which is built with `panic = "abort"` aborts
when calling into cbdingen functionality.

mozilla#569

Signed-off-by: Grant Elbert <[email protected]>
elbe0046 added a commit to elbe0046/cbindgen that referenced this issue Jun 20, 2021
@elbe0046
parser: force proc macro fallback
7f757d5 
Incorporate dtolnay/proc-macro2#220 to fix
the case where a binary which is built with `panic = "abort"` aborts
when calling into cbindgen functionality.

mozilla#569

Signed-off-by: Grant Elbert <[email protected]>
elbe0046 added a commit to elbe0046/cbindgen that referenced this issue Jun 20, 2021
@elbe0046
parser: force proc macro fallback
57918e9 
Incorporate dtolnay/proc-macro2#220 to fix
the case where a binary which is built with `panic = "abort"` aborts
when calling into cbindgen functionality.

mozilla#569

Signed-off-by: Grant Elbert <[email protected]>
@elbe0046 elbe0046 mentioned this issue Jun 20, 2021
Closed
@jschwe
Copy link
Contributor

jschwe commented May 31, 2023

Can this issue be closed? The upstream issues was closed end of 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@h33p @jschwe