-
-
Notifications
You must be signed in to change notification settings - Fork 126
[docs] Radio docs are incorrect/lacking #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Another issue: |
It says "beside" not "inside"
For form controls specifically, we recommend using the
Makes sense, the docs in this case can be better |
Oops, my bad. I should read what I copy/paste more carefully. 😄
Awesome, thanks for the tip! |
Note: I noticed the exact same issue with the Menu.RadioItem component. |
Uh oh!
There was an error while loading. Please reload this page.
Docs feedback
How can we improve Base UI documentation?
The docs for the Radio.Root component mention:
But that's incorrect; the hidden
<input>
seems to be rendered as a sibling of the<button>
element rather than inside it.Which begs the question... why can't
<Radio.Root>
actually render a<label>
that contains both the<button>
and the<input>
? Seems strange to have to wrap it in a<label>
ourselves, as per the example... it's not really documented so maybe that's optional, but if we don't wrap it in a<label>
, how is the radio going to be labelled?The text was updated successfully, but these errors were encountered: