Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Dependency on ^6.0.0 when MUI-X is supposedly MUI v7 only #17218

Open
corytam opened this issue Apr 1, 2025 · 2 comments
Open

[pickers] Dependency on ^6.0.0 when MUI-X is supposedly MUI v7 only #17218

corytam opened this issue Apr 1, 2025 · 2 comments
Labels
bug 🐛 Something doesn't work stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. status: waiting for author Issue with insufficient information v7.x

Comments

@corytam
Copy link

corytam commented Apr 1, 2025

Steps to reproduce

Steps:

  1. Install @mui/material
  2. Install @mui/x-date-pickers

Current behavior

When attempting to install / update material via npm , I get error

I also did a clean reinstall with the latest versions and getting the same issue

npm ERR! While resolving: @mui/[email protected]
npm ERR! Found: @mui/[email protected]
npm ERR! node_modules/@mui/material
npm ERR! peer @mui/material@"^7.0.1" from @mui/[email protected]
npm ERR! node_modules/@mui/icons-material
npm ERR! @mui/icons-material@"^7.0.1" from the root project
npm ERR! @mui/material@"^7.0.1" from the root project
npm ERR! 1 more (@mui/lab)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @mui/material@"^5.15.14 || ^6.0.0" from @mui/[email protected]
npm ERR! node_modules/@mui/x-date-pickers
npm ERR! @mui/x-date-pickers@"^7.23.3" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @mui/[email protected]
npm ERR! node_modules/@mui/material
npm ERR! peer @mui/material@"^5.15.14 || ^6.0.0" from @mui/[email protected]
npm ERR! node_modules/@mui/x-date-pickers
npm ERR! @mui/x-date-pickers@"^7.23.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Expected behavior

No need to override install with --legacy-peer-deps flag

Context

Based on #16771 , it seems like MUI-X components are to only support MUI v7 . I'm not sure what im doing wrong ,but when i tried to update to MUI v7 , i got issues with x-date-pickers having a peer dependency on v^6

I dug into the files of x-date-pickers and it seems the package.json doesnt reference v7 and matches the peer dependency error above.

For now I am overriding with
npm install --legacy-peer-deps

[My own package.json - dependecies]

"dependencies": {
...
"@mui/icons-material": "^7.0.1",
"@mui/lab": "^7.0.0-beta.10",
"@mui/material": "^7.0.1",
"@mui/x-date-pickers": "^7.23.3",

Your environment

npx @mui/envinfo

System:
OS: Windows 11 10.0.26100
Binaries:
Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
pnpm: Not Found
Browsers:
Chrome: Not Found
Edge: Chromium (132.0.2957.115)
npmPackages:
@emotion/react: ^11.14.0 => 11.14.0
@emotion/styled: ^11.14.0 => 11.14.0
@mui/core-downloads-tracker: 7.0.1
@mui/icons-material: ^7.0.1 => 7.0.1
@mui/lab: ^7.0.0-beta.10 => 7.0.0-beta.10
@mui/material: ^7.0.1 => 7.0.1
@mui/private-theming: 7.0.1
@mui/styled-engine: 7.0.1
@mui/system: 7.0.1
@mui/types: ^7.4.0 => 7.4.0
@mui/utils: 6.4.9
@mui/x-date-pickers: ^7.23.3 => 7.23.3
@mui/x-internals: 7.23.0
@types/react: ^18.3.18 => 18.3.18
react: ^18.3.1 => 18.3.1
react-dom: ^18.3.1 => 18.3.1
typescript: ~5.6.2 => 5.6.3

Search keywords: Date Pickers

@corytam corytam added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 1, 2025
@michelengelen
Copy link
Member

You are correct that we are aiming to only support material-ui with version 7 or higher with this major release, not the latest. So the support on v7 of MUI-X products should still be v6, and v5.

@michelengelen michelengelen added status: waiting for author Issue with insufficient information v7.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 1, 2025
@michelengelen michelengelen changed the title X-Date-Pickers dependency on ^6.0.0 when MUI-X is supposedly MUI v7 only [ickers] Dependency on ^6.0.0 when MUI-X is supposedly MUI v7 only Apr 1, 2025
@flaviendelangle flaviendelangle changed the title [ickers] Dependency on ^6.0.0 when MUI-X is supposedly MUI v7 only [pickers] Dependency on ^6.0.0 when MUI-X is supposedly MUI v7 only Apr 4, 2025
Copy link

This issue has been inactive for 7 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 5 days.

@github-actions github-actions bot added the stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. status: waiting for author Issue with insufficient information v7.x
Projects
None yet
Development

No branches or pull requests

2 participants