Skip to content

Commit c0b1b40

Browse files
authored
fix: use base hash for cache (#216)
Otherwise master doesn't build for release
1 parent d387160 commit c0b1b40

File tree

2 files changed

+32
-32
lines changed

2 files changed

+32
-32
lines changed

.github/workflows/main.yml

+32-31
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
./node_modules
2828
./packages/*/dist
2929
./packages/*/node_modules
30-
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
30+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
3131
- name: Install Dependencies
3232
if: steps.cache.outputs.cache-hit != 'true'
3333
run: |
@@ -60,7 +60,7 @@ jobs:
6060
./node_modules
6161
./packages/*/dist
6262
./packages/*/node_modules
63-
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
63+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
6464
- name: Install Dependencies
6565
if: steps.cache.outputs.cache-hit != 'true'
6666
run: |
@@ -88,7 +88,7 @@ jobs:
8888
./node_modules
8989
./packages/*/dist
9090
./packages/*/node_modules
91-
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
91+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
9292
- name: Install Dependencies
9393
if: steps.cache.outputs.cache-hit != 'true'
9494
run: |
@@ -115,7 +115,7 @@ jobs:
115115
./node_modules
116116
./packages/*/dist
117117
./packages/*/node_modules
118-
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
118+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
119119
- name: Install Dependencies
120120
if: steps.cache.outputs.cache-hit != 'true'
121121
run: |
@@ -142,39 +142,40 @@ jobs:
142142
./node_modules
143143
./packages/*/dist
144144
./packages/*/node_modules
145-
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
145+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
146146
- name: Install Dependencies
147147
if: steps.cache.outputs.cache-hit != 'true'
148148
run: |
149149
npm install
150150
npm run --if-present build
151151
- run: npx xvfb-maybe npm run --if-present test:electron-main --bail
152152

153-
# test-electron-renderer:
154-
# needs: check
155-
# runs-on: ubuntu-latest
156-
# steps:
157-
# - uses: actions/checkout@v2
158-
# - uses: actions/setup-node@v2
159-
# with:
160-
# node-version: lts/*
161-
# - uses: actions/cache@v2
162-
# id: cache
163-
# env:
164-
# CACHE_NAME: cache-node-modules
165-
# with:
166-
# path: |
167-
# ~/.npm
168-
# ./node_modules
169-
# ./packages/*/node_modules
170-
# ./packages/*/dist
171-
# key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
172-
# - name: Install Dependencies
173-
# if: steps.cache.outputs.cache-hit != 'true'
174-
# run: |
175-
# npm run --if-present build
176-
# npm install
177-
# - run: npx xvfb-maybe npm run --if-present test:electron-renderer --bail
153+
test-electron-renderer:
154+
needs: check
155+
runs-on: ubuntu-latest
156+
steps:
157+
- uses: actions/checkout@v2
158+
- uses: actions/setup-node@v2
159+
with:
160+
node-version: lts/*
161+
- uses: actions/cache@v2
162+
id: cache
163+
env:
164+
CACHE_NAME: cache-node-modules
165+
with:
166+
path: |
167+
~/.npm
168+
./dist
169+
./node_modules
170+
./packages/*/dist
171+
./packages/*/node_modules
172+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
173+
- name: Install Dependencies
174+
if: steps.cache.outputs.cache-hit != 'true'
175+
run: |
176+
npm install
177+
npm run --if-present build
178+
- run: npx xvfb-maybe npm run --if-present test:electron-renderer --bail
178179

179180
release:
180181
needs: [test-node, test-chrome, test-firefox, test-electron-main]
@@ -198,7 +199,7 @@ jobs:
198199
./node_modules
199200
./packages/*/dist
200201
./packages/*/node_modules
201-
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.event.pull_request.head.sha }}
202+
key: ${{ runner.os }}-build-${{ env.CACHE_NAME }}-${{ github.sha }}
202203
- name: Install Dependencies
203204
if: steps.cache.outputs.cache-hit != 'true'
204205
run: |

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"test:browser": "aegir test -t browser -f ./dist/test/**/*.js",
2323
"test:node": "aegir test -t node -f ./dist/test/**/*.js",
2424
"test:electron-main": "aegir test -t electron-main -f ./dist/test/**/*.js",
25-
"test:electron-renderer": "aegir test -t electron-renderer -f ./dist/test/**/*.js",
2625
"lint": "aegir ts -p check && aegir lint",
2726
"build": "tsc",
2827
"dep-check": "aegir dep-check dist/src/**/*.js dist/test/**/*.js",

0 commit comments

Comments
 (0)