Review

Author: FileEX

Client/game_sa/C2DEffectSA.cpp

@@ -35,7 +35,7 @@ void C2DEffectSA::SetPosition(const CVector& position)
         m_effectInterface->position = RwV3d{position.fX, position.fY, position.fZ};
 }
 
-CVector& C2DEffectSA::GetPosition()
+CVector& C2DEffectSA::GetPosition() const
 {
     if (m_effectInterface)
         return CVector(m_effectInterface->position.x, m_effectInterface->position.y, m_effectInterface->position.z);

Client/game_sa/C2DEffectSA.h

@@ -51,7 +51,7 @@ class C2DEffectSA : public C2DEffect
     void Destroy() const;
 
     void SetPosition(const CVector& position) override;
-    CVector& GetPosition() override;
+    CVector& GetPosition() const override;
 
     // Light properties
     // Set

Client/mods/deathmatch/logic/CClient2DFXManager.cpp

@@ -162,8 +162,6 @@ effectDataMap CClient2DFXManager::Get2DFXProperties(C2DEffect* effect) const
 
             break;
         }
-        default:
-            break;
     }
 
     return properties;
@@ -352,8 +350,6 @@ bool CClient2DFXManager::Set2DFXProperty(C2DEffect* effect, const e2dEffectPrope
 
                     break;
                 }
-                default:
-                    break;
             }
 
             break;
@@ -485,8 +481,6 @@ bool CClient2DFXManager::Set2DFXProperty(C2DEffect* effect, const e2dEffectPrope
 
                     break;
                 }
-                default:
-                    break;
             }
             break;
         }
@@ -616,8 +610,6 @@ bool CClient2DFXManager::Set2DFXProperty(C2DEffect* effect, const e2dEffectPrope
 
             break;
         }
-        default:
-            break;
     }
 
     return false;
@@ -735,8 +727,6 @@ std::variant<float, bool, std::string> CClient2DFXManager::Get2DFXProperty(C2DEf
 
             break;
         }
-        default:
-            break;
     }
 
     return false;

Client/sdk/game/C2DEffect.h

@@ -22,7 +22,7 @@ class C2DEffect
 {
 public:
     virtual void SetPosition(const CVector& position) = 0;
-    virtual CVector& GetPosition() = 0;
+    virtual CVector& GetPosition() const = 0;
 
     virtual e2dEffectType GetEffectType() = 0;