Fix 8.3 compat and deprecations

Author: mvdbos

.github/workflows/php.yml

@@ -14,7 +14,7 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ ubuntu-latest ]
-        php-versions: [ '8.0', '8.1', '8.2' ]
+        php-versions: [ '8.0', '8.1', '8.2', '8.3' ]
 
     steps:
       - uses: actions/checkout@v4

.phan/config.php

@@ -52,7 +52,7 @@
     // Note that the **only** effect of choosing `'5.6'` is to infer that functions removed in php 7.0 exist.
     // (See `backward_compatibility_checks` for additional options)
     // Automatically inferred from composer.json requirement for "php" of ">=7.3"
-    'target_php_version' => null,
+    'target_php_version' => '8.3',
 
     // If enabled, missing properties will be created when
     // they are first seen. If false, we'll report an

bin/static-analysis

@@ -54,8 +54,6 @@ runCheck "phpcs 'src/'"        "vendor/bin/phpcs --warning-severity=0 --standard
 runCheck "phpcs 'tests/'"      "vendor/bin/phpcs --warning-severity=0 --standard=PSR2 tests/"
 runCheck "phpmd 'src/'"        "vendor/bin/phpmd src/ text phpmd.xml"
 runCheck "phpmd 'tests/'"      "vendor/bin/phpmd tests/ text phpmd-tests.xml"
-runCheck "phpcpd 'src/'"       "vendor/bin/phpcpd --min-lines=7 --min-tokens=30  --fuzzy -v src/"
-runCheck "phpcpd 'tests/'"     "vendor/bin/phpcpd --min-lines=10 --min-tokens=100  --fuzzy tests/"
 runCheck "phan"                "PHAN_DISABLE_XDEBUG_WARN=1 vendor/bin/phan  --no-progress-bar 2>/dev/null"
 
 echo -e "\n\n\e[0;37;42mStatic analysis completed successfully.\e[0m\n"

composer.json

@@ -31,8 +31,7 @@
         "phpunit/phpunit": "^9.0.0",
         "squizlabs/php_codesniffer": "^3.0.0",
         "phpmd/phpmd": "^2.0.0",
-        "sebastian/phpcpd": "^6.0.0",
-        "friendsofphp/php-cs-fixer": "^3.16.0"
+        "friendsofphp/php-cs-fixer": "^3.69.0"
     },
     "autoload": {
         "psr-4": {

src/Downloader/Downloader.php

@@ -38,8 +38,8 @@ class Downloader implements DownloaderInterface
      * @param int $downloadLimit
      */
     public function __construct(
-        PersistenceHandlerInterface $persistenceHandler = null,
-        RequestHandlerInterface $requestHandler = null,
+        ?PersistenceHandlerInterface $persistenceHandler = null,
+        ?RequestHandlerInterface $requestHandler = null,
         array $postFetchFilters = array(),
         int $downloadLimit = 0
     ) {

src/Filter/Prefetch/RobotsTxtDisallowFilter.php

@@ -27,7 +27,7 @@ class RobotsTxtDisallowFilter implements PreFetchFilterInterface
      * @throws ErrorException
      * @throws UriSyntaxException
      */
-    public function __construct(string $seedUrl, string $userAgent = null)
+    public function __construct(string $seedUrl, ?string $userAgent = null)
     {
         $this->seedUri = new Uri($seedUrl);
         $this->seedUri->normalize();

src/RequestHandler/GuzzleRequestHandler.php

@@ -20,7 +20,7 @@ class GuzzleRequestHandler implements RequestHandlerInterface
      * GuzzleRequestHandler constructor.
      * @param Client|null $client
      */
-    public function __construct(Client $client = null)
+    public function __construct(?Client $client = null)
     {
         $this->setClient($client ?: new Client());
     }

src/Spider.php

@@ -35,10 +35,10 @@ class Spider
      */
     public function __construct(
         string $seed,
-        DiscovererSet $discovererSet = null,
-        QueueManagerInterface $queueManager = null,
-        DownloaderInterface  $downloader = null,
-        string $spiderId = null
+        ?DiscovererSet $discovererSet = null,
+        ?QueueManagerInterface $queueManager = null,
+        ?DownloaderInterface  $downloader = null,
+        ?string $spiderId = null
     ) {
         $this->setSeed($seed);
         $this->setSpiderId($spiderId);