From 8c95bed9adfb36113127bf383f2072d2ac66a78d Mon Sep 17 00:00:00 2001 From: Kris Williams Date: Mon, 3 Apr 2017 14:49:09 -0700 Subject: [PATCH 1/3] Minor adjustment needed for latest ember-cli-deploy-plugin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The pluginConfig is the bound `this` to the `deployClient` function. Also, the bound `this` doesn’t have a `this.readConfig()` but the `pluginHelper` argument does. --- index.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/index.js b/index.js index 8a669c5..1e6e7dc 100644 --- a/index.js +++ b/index.js @@ -39,12 +39,10 @@ module.exports = { revisionKey: function (context) { return context.commandOptions.revision || (context.revisionData && context.revisionData.revisionKey); }, - deployClient: function (context) { - var mysqlOptions = this.pluginConfig; - mysqlOptions.port = this.readConfig('port'); + deployClient: function (context, pluginHelper) { + this.port = pluginHelper.readConfig('port'); var mysqlLib = context._mysqlLib; - - return new MySQL(mysqlOptions, mysqlLib); + return new MySQL(this, mysqlLib); }, didDeployMessage: function (context) { var revisionKey = context.revisionData && context.revisionData.revisionKey; From cfbb18da8243c5cf51184bc77438b148bd955393 Mon Sep 17 00:00:00 2001 From: Kris Williams Date: Tue, 16 May 2017 16:50:36 -0700 Subject: [PATCH 2/3] clean up deprecation warning ember-cli/lib/ext/promise is no longer used, and marked as deprecated. --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index 1e6e7dc..2f2627b 100644 --- a/index.js +++ b/index.js @@ -1,7 +1,7 @@ /* jshint node: true */ 'use strict'; -var Promise = require('ember-cli/lib/ext/promise'); +var Promise = require('rsvp').Promise; var DeployPluginBase = require('ember-cli-deploy-plugin'); var path = require('path'); From 16fff78fa45889f64b963af237c27923d09585af Mon Sep 17 00:00:00 2001 From: Tom Lagier Date: Thu, 27 Jul 2017 15:44:19 -0700 Subject: [PATCH 3/3] Don't create or delete, please --- lib/mysql.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mysql.js b/lib/mysql.js index 2847d60..a227b4d 100644 --- a/lib/mysql.js +++ b/lib/mysql.js @@ -55,10 +55,10 @@ module.exports = CoreObject.extend({ var maxEntries = this._maxRecentUploads; return Promise.resolve() - .then(this._createIfTableDoesNotExist.bind(this, tableName)) + //.then(this._createIfTableDoesNotExist.bind(this, tableName)) .then(this._uploadIfKeyDoesNotExist.bind(this, tableName, revisionKey, value)) .then(this._listRevisions.bind(this, tableName)) - .then(this._trimRecentUploadsList.bind(this, tableName, maxEntries)) + //.then(this._trimRecentUploadsList.bind(this, tableName, maxEntries)) .then(function () { return [tableName, revisionKey]; });