fix: cleanup from #7029 (#7328)

* refactor: fix issues arose from #7029

* refactor: move replaceAll -> replace in makeKeyString

* fix: move order of escape to backslash first

* style: lint

Author: tristan-f-r

src/api/objects/object-utils.js

@@ -99,7 +99,9 @@ function makeKeyString(identifier) {
     return identifier.key;
   }
 
-  return [identifier.namespace.replace(/:/g, '\\:'), identifier.key].join(':');
+  return [identifier.namespace.replace(/\\/g, '\\\\').replace(/:/g, '\\:'), identifier.key].join(
+    ':'
+  );
 }
 
 /**

src/plugins/autoflow/AutoflowTabularPlugin.js

@@ -35,7 +35,7 @@ export default function (options) {
         return !options || options.type === d.type;
       },
       view: function (domainObject) {
-        return new AutoflowTabularView(domainObject, openmct, document);
+        return new AutoflowTabularView(domainObject, openmct);
       }
     });
   };

src/plugins/conditionWidget/components/ConditionWidget.vue

@@ -34,8 +34,9 @@
 </template>
 
 <script>
+import { sanitizeUrl } from '@braintree/sanitize-url';
+
 import tooltipHelpers from '../../../api/tooltips/tooltipMixins';
-const sanitizeUrl = require('@braintree/sanitize-url').sanitizeUrl;
 
 export default {
   mixins: [tooltipHelpers],

src/plugins/hyperlink/HyperlinkLayout.vue

@@ -34,7 +34,7 @@
 </template>
 
 <script>
-const sanitizeUrl = require('@braintree/sanitize-url').sanitizeUrl;
+import { sanitizeUrl } from '@braintree/sanitize-url';
 
 export default {
   inject: ['domainObject'],

src/plugins/timer/components/TimerComponent.vue

@@ -44,12 +44,11 @@
 </template>
 
 <script>
+import momentDurationFormatSetup from 'moment-duration-format';
+import moment from 'moment-timezone';
 import raf from 'utils/raf';
 
 import throttle from '../../../utils/throttle';
-
-const moment = require('moment-timezone');
-const momentDurationFormatSetup = require('moment-duration-format');
 const refreshRateSeconds = 2;
 
 momentDurationFormatSetup(moment);

src/plugins/webPage/components/WebPage.vue

@@ -26,7 +26,7 @@
 </template>
 
 <script>
-const sanitizeUrl = require('@braintree/sanitize-url').sanitizeUrl;
+import { sanitizeUrl } from '@braintree/sanitize-url';
 
 export default {
   inject: ['openmct', 'domainObject'],

src/ui/router/ApplicationRouter.js

@@ -19,11 +19,10 @@
  * this source code distribution or the Licensing information page available
  * at runtime from the About dialog for additional information.
  *****************************************************************************/
-/*global module*/
 
-const LocationBar = require('location-bar');
-const EventEmitter = require('EventEmitter');
-const _ = require('lodash');
+import EventEmitter from 'EventEmitter';
+import LocationBar from 'location-bar';
+import _ from 'lodash';
 
 class ApplicationRouter extends EventEmitter {
   /**
@@ -430,4 +429,4 @@ function paramsToObject(searchParams) {
   return params;
 }
 
-module.exports = ApplicationRouter;
+export default ApplicationRouter;