Skip to content

Commit 3c61c87

Browse files
authored
Merge pull request #358 from eebus/1.3-kerberos-principal
Added empty principal to fix kerberos AuthToken
2 parents acf5a07 + 1facc66 commit 3c61c87

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

driver/src/main/java/org/neo4j/driver/v1/AuthTokens.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ public static AuthToken kerberos( String base64EncodedTicket )
7676
{
7777
return new InternalAuthToken( parameters(
7878
"scheme", "kerberos",
79+
"principal", "", //This empty string is required for backwards compatibility.
7980
"credentials", base64EncodedTicket).asMap( Values.ofValue() ) );
8081
}
8182

driver/src/test/java/org/neo4j/driver/v1/AuthTokensTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,16 @@ public void customAuthParameters()
9898
assertThat( map.get( "realm" ), equalTo( (Value) new StringValue( "baz" ) ) );
9999
assertThat( map.get( "parameters" ), equalTo( (Value) new MapValue( expectedParameters ) ) );
100100
}
101+
102+
@Test
103+
public void basicKerberosAuthWithRealm()
104+
{
105+
InternalAuthToken token = (InternalAuthToken) AuthTokens.kerberos( "base64" );
106+
Map<String,Value> map = token.toMap();
107+
108+
assertThat( map.size(), equalTo( 3 ) );
109+
assertThat( map.get( "scheme" ), equalTo( (Value) new StringValue( "kerberos" ) ) );
110+
assertThat( map.get( "principal" ), equalTo( (Value) new StringValue( "" ) ) );
111+
assertThat( map.get( "credentials" ), equalTo( (Value) new StringValue( "base64" ) ) );
112+
}
101113
}

0 commit comments

Comments
 (0)