Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager.Focus: tree walking #6129

Open
tobiu opened this issue Nov 22, 2024 · 2 comments
Open

manager.Focus: tree walking #6129

tobiu opened this issue Nov 22, 2024 · 2 comments
Labels
enhancement New feature or request no auto close

Comments

@tobiu
Copy link
Collaborator

tobiu commented Nov 22, 2024

I think we can do better here:

Right now, we parse the DOM paths and map them to related neo components. While this does work fine for nested widgets inside the DOM tree, it does not honor overlays as good as it should.

We should only fetch the closest component inside the focusin & focusout path and from there use the component tree.

  1. find the closest common ancestor
  2. walk the out path component tree upwards and fire focusLeave
  3. walk the in path component tree upwards and fire focusEnter
  4. fire focusMove on the common ancestor

It relies on floating components to be placed inside the component tree correctly.

@rwaters

@tobiu tobiu added the enhancement New feature or request label Nov 22, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Feb 21, 2025
Copy link

github-actions bot commented Mar 7, 2025

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2025
@tobiu tobiu reopened this Apr 5, 2025
@tobiu tobiu added no auto close and removed stale labels Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no auto close
Projects
None yet
Development

No branches or pull requests

1 participant