Skip to content

[Housekeeping]: Use JSONField for assigned_object serializer #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pheus opened this issue Mar 21, 2025 · 0 comments · Fixed by #248
Closed

[Housekeeping]: Use JSONField for assigned_object serializer #247

pheus opened this issue Mar 21, 2025 · 0 comments · Fixed by #248

Comments

@pheus
Copy link
Contributor

pheus commented Mar 21, 2025

Proposed Changes

  • Replace DictField with JSONField for the assigned_object serializer.
  • Ensure the schema field returns None when assigned_object is missing, without causing errors.
  • Add a string representation for the "display" attribute in the ACLInterfaceAssignment API.

Justification

  • Since this is a REST API, using JSONField is more appropriate and aligns with NetBox core best practices.
  • The "display" attribute is a common pattern in the NetBox API, so it should be included in ACLInterfaceAssignment for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant