Skip to content

Commit e65dd04

Browse files
committed
Merge branch 'master' of https://github.com/rollup/rollup into sync-ce6cb930
2 parents 98ede97 + ce6cb93 commit e65dd04

File tree

10 files changed

+87
-6
lines changed

10 files changed

+87
-6
lines changed

src/ast/nodes/MetaProperty.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ const getGenericImportMetaMechanism =
175175
const getFileUrlFromFullPath = (path: string) => `require('u' + 'rl').pathToFileURL(${path}).href`;
176176

177177
const getFileUrlFromRelativePath = (path: string) =>
178-
getFileUrlFromFullPath(`__dirname + '/${path}'`);
178+
getFileUrlFromFullPath(`__dirname + '/${escapeId(path)}'`);
179179

180180
const getUrlFromDocument = (chunkId: string, umd = false) =>
181181
`${
@@ -187,15 +187,15 @@ const getUrlFromDocument = (chunkId: string, umd = false) =>
187187
const relativeUrlMechanisms: Record<InternalModuleFormat, (relativePath: string) => string> = {
188188
amd: relativePath => {
189189
if (relativePath[0] !== '.') relativePath = './' + relativePath;
190-
return getResolveUrl(`require.toUrl('${relativePath}'), document.baseURI`);
190+
return getResolveUrl(`require.toUrl('${escapeId(relativePath)}'), document.baseURI`);
191191
},
192192
cjs: relativePath =>
193193
`(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
194194
relativePath
195195
)} : ${getRelativeUrlFromDocument(relativePath)})`,
196-
es: relativePath => getResolveUrl(`'${relativePath}', import.meta.url`),
196+
es: relativePath => getResolveUrl(`'${escapeId(relativePath)}', import.meta.url`),
197197
iife: relativePath => getRelativeUrlFromDocument(relativePath),
198-
system: relativePath => getResolveUrl(`'${relativePath}', module.meta.url`),
198+
system: relativePath => getResolveUrl(`'${escapeId(relativePath)}', module.meta.url`),
199199
umd: relativePath =>
200200
`(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
201201
relativePath

test/form/samples/emit-asset-file/_config.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = defineTest({
2424
},
2525
generateBundle(options, outputBundle) {
2626
const keys = Object.keys(outputBundle);
27-
assert.strictEqual(keys.length, 2);
27+
assert.strictEqual(keys.length, 3);
2828
assert.strictEqual(keys[0], 'assets/logo-zDlmrXar.svg');
2929
const asset = outputBundle[keys[0]];
3030
assert.strictEqual(asset.fileName, 'assets/logo-zDlmrXar.svg');
@@ -37,7 +37,8 @@ module.exports = defineTest({
3737
source.equals(readFileSync(path.resolve(__dirname, 'logo.svg'))),
3838
'asset has correct source'
3939
);
40-
assert.ok(keys[1].endsWith('.js'), `${keys[1]} ends with ".js"`);
40+
assert.ok(keys[1].endsWith('.svg'), `${keys[1]} ends with ".svg"`);
41+
assert.ok(keys[2].endsWith('.js'), `${keys[2]} ends with ".js"`);
4142
}
4243
}
4344
]

test/form/samples/emit-asset-file/_expected/amd.js

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ define(['require'], (function (require) { 'use strict';
22

33
var logo = new URL(require.toUrl('./assets/logo-zDlmrXar.svg'), document.baseURI).href;
44

5+
var logoReverse = new URL(require.toUrl('./assets/logo_reverse\'-DbGK2oiS.svg'), document.baseURI).href;
6+
57
function showImage(url) {
68
console.log(url);
79
if (typeof document !== 'undefined') {
@@ -12,5 +14,6 @@ define(['require'], (function (require) { 'use strict';
1214
}
1315

1416
showImage(logo);
17+
showImage(logoReverse);
1518

1619
}));

test/form/samples/emit-asset-file/_expected/cjs.js

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
var logo = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__dirname + '/assets/logo-zDlmrXar.svg').href : new URL('assets/logo-zDlmrXar.svg', document.currentScript && document.currentScript.src || document.baseURI).href);
44

5+
var logoReverse = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__dirname + '/assets/logo_reverse\'-DbGK2oiS.svg').href : new URL('assets/logo_reverse\'-DbGK2oiS.svg', document.currentScript && document.currentScript.src || document.baseURI).href);
6+
57
function showImage(url) {
68
console.log(url);
79
if (typeof document !== 'undefined') {
@@ -12,3 +14,4 @@ function showImage(url) {
1214
}
1315

1416
showImage(logo);
17+
showImage(logoReverse);

test/form/samples/emit-asset-file/_expected/es.js

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
var logo = new URL('assets/logo-zDlmrXar.svg', import.meta.url).href;
22

3+
var logoReverse = new URL('assets/logo_reverse\'-DbGK2oiS.svg', import.meta.url).href;
4+
35
function showImage(url) {
46
console.log(url);
57
if (typeof document !== 'undefined') {
@@ -10,3 +12,4 @@ function showImage(url) {
1012
}
1113

1214
showImage(logo);
15+
showImage(logoReverse);

test/form/samples/emit-asset-file/_expected/iife.js

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
var logo = new URL('assets/logo-zDlmrXar.svg', document.currentScript && document.currentScript.src || document.baseURI).href;
55

6+
var logoReverse = new URL('assets/logo_reverse\'-DbGK2oiS.svg', document.currentScript && document.currentScript.src || document.baseURI).href;
7+
68
function showImage(url) {
79
console.log(url);
810
if (typeof document !== 'undefined') {
@@ -13,5 +15,6 @@
1315
}
1416

1517
showImage(logo);
18+
showImage(logoReverse);
1619

1720
})();

test/form/samples/emit-asset-file/_expected/system.js

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ System.register([], (function (exports, module) {
55

66
var logo = new URL('assets/logo-zDlmrXar.svg', module.meta.url).href;
77

8+
var logoReverse = new URL('assets/logo_reverse\'-DbGK2oiS.svg', module.meta.url).href;
9+
810
function showImage(url) {
911
console.log(url);
1012
if (typeof document !== 'undefined') {
@@ -15,6 +17,7 @@ System.register([], (function (exports, module) {
1517
}
1618

1719
showImage(logo);
20+
showImage(logoReverse);
1821

1922
})
2023
};

test/form/samples/emit-asset-file/_expected/umd.js

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
var logo = (typeof document === 'undefined' && typeof location === 'undefined' ? require('u' + 'rl').pathToFileURL(__dirname + '/assets/logo-zDlmrXar.svg').href : new URL('assets/logo-zDlmrXar.svg', typeof document === 'undefined' ? location.href : document.currentScript && document.currentScript.src || document.baseURI).href);
77

8+
var logoReverse = (typeof document === 'undefined' && typeof location === 'undefined' ? require('u' + 'rl').pathToFileURL(__dirname + '/assets/logo_reverse\'-DbGK2oiS.svg').href : new URL('assets/logo_reverse\'-DbGK2oiS.svg', typeof document === 'undefined' ? location.href : document.currentScript && document.currentScript.src || document.baseURI).href);
9+
810
function showImage(url) {
911
console.log(url);
1012
if (typeof document !== 'undefined') {
@@ -15,5 +17,6 @@
1517
}
1618

1719
showImage(logo);
20+
showImage(logoReverse);
1821

1922
}));
Loading

test/form/samples/emit-asset-file/main.js

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import logo from './logo.svg';
2+
import logoReverse from "./logo_reverse'.svg"
23

34
function showImage(url) {
45
console.log(url);
@@ -10,3 +11,4 @@ function showImage(url) {
1011
}
1112

1213
showImage(logo);
14+
showImage(logoReverse);

0 commit comments

Comments
 (0)