Skip to content

Commit 3795ddc

Browse files
committed
Revert "Use local state"
This reverts commit 2ae7c02.
1 parent 8091abc commit 3795ddc

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

notebooks/table_filters.clj

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
^{:nextjournal.clerk/visibility {:result :show}}
6262
@viewer/!sync-state
6363

64-
#_(reset! viewer/!sync-state {})
64+
#_(reset! viewer/!sync-state {:active-filters {}})
6565

6666
^{:nextjournal.clerk/visibility {:result :show}}
6767
(clerk/with-viewer clerk-table-stats/viewer

src/nextjournal/clerk_table_stats.cljc

+1-4
Original file line numberDiff line numberDiff line change
@@ -493,10 +493,7 @@
493493
(assoc viewer/table-viewer
494494
:transform-fn
495495
(fn transform-fn [{:as wrapped-value :nextjournal/keys [applied-viewer render-opts]}]
496-
;; TODO: drop this `(str (:id wrapped-value) "-result")`
497-
;; processing once we unify the `:id` in clerk between
498-
;; render-opts and transform-fn
499-
(let [table-state (get-in @(:!sync-state wrapped-value) [(str (:id wrapped-value) "-result")])]
496+
(let [table-state @(:!sync-state wrapped-value)]
500497

501498
(if-let [{:keys [head rows summary filter-data autocomplete-data state]}
502499
(normalize-table-data (merge render-opts table-state)

src/nextjournal/clerk_table_stats/render.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@
836836

837837
(defn table-markup-viewer [head+body {:as opts :keys [!sync-state]}]
838838
(r/with-let [table-state (if !sync-state
839-
(r/cursor !sync-state [(:id opts)])
839+
!sync-state
840840
#?(:clj (throw (js/Error. (str "no sync var: " !sync-state)))
841841
:cljs nil))]
842842
[:div

0 commit comments

Comments
 (0)